1337291 - Support borderStyle for WebRenderBorderLayer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ethan Lin[:ethlin]]

Currently we don't support borderStyle. And we should support it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: support border style for webrenderborderlayer

I pass the border style to WR from OpDPPushBorder, just using the same way as width/radius. I also remove some checks in nsDisplayBorder::GetLayerState for WebRenderLayerManager.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: support border style for webrenderborderlayer

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8834311 [details] [diff] [review]
support border style for webrenderborderlayer

Review of attachment 8834311 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +4405,5 @@
> +
> +    NS_FOR_CSS_SIDES(i) {
> +      mColors[i] = ToDeviceColor(br->mBorderColors[i]);
> +      mWidths[i] = br->mBorderWidths[i];
> +      mBorderStyles[i] = br->mBorderStyles[i];

We should make sure we initialize mBorderStyles in the !LAYERS_WR case.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> Comment on attachment 8834311 [details] [diff] [review]
> support border style for webrenderborderlayer
> 
> Review of attachment 8834311 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/painting/nsDisplayList.cpp
> @@ +4405,5 @@
> > +
> > +    NS_FOR_CSS_SIDES(i) {
> > +      mColors[i] = ToDeviceColor(br->mBorderColors[i]);
> > +      mWidths[i] = br->mBorderWidths[i];
> > +      mBorderStyles[i] = br->mBorderStyles[i];
> 
> We should make sure we initialize mBorderStyles in the !LAYERS_WR case.

You are right! I should initialize mBorderStyles for non-WR case.

Comment 5

[Ethan Lin[:ethlin]]

I'll split the patch into two part. One is for m-c, and the other one is for graphics branch. And I should turn on the pref for some reftests about border-style.

Comment 6

[Ethan Lin[:ethlin]]

Attachment: Part1. Pass the border style to BorderLayer. r=mattwoodrow

The patch is split from the original patch for m-c.

Comment 7

[Ethan Lin[:ethlin]]

Attachment: Part2. Pass border style to webrender. r=mattwoodrow

The patch is for graphics branch.

Comment 8

[Ethan Lin[:ethlin]]

Attachment: Part3. Turn on the pref in a reftest for border style

Comment 9

[Ethan Lin[:ethlin]]

Attachment: Part1. Pass the border style to BorderLayer. r=mattwoodrow

m-c dones't know LAYER_WR, so I should move the check of LAYER_WR to Part2.

Comment 10

[Ethan Lin[:ethlin]]

Attachment: Part2. Pass border style to webrender. r=mattwoodrow

Update part2 since part1 changed.

Comment 11

[Ethan Lin[:ethlin]]

Please push attachment 8835226 [details] [diff] [review] to m-c.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a736bb1b9524
Part1. Pass the border style to BorderLayer. r=mattwoodrow

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a736bb1b9524

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8835226 [details] [diff] [review]
Part1. Pass the border style to BorderLayer. r=mattwoodrow

This got merged back to the graphics branch in e79bf3dc8926

Comment 15

[Ethan Lin[:ethlin]]

try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=359b3f2e1a0e0c4223b140dd6b03385a4ef81085

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/07ec3c306ad2
Part2. Pass border style to webrender. r=mattwoodrow
https://hg.mozilla.org/projects/graphics/rev/67bb1f6342fa
Part3. Enable a reftest for WebRenderBorderlayer's border style. r=pchang