Closed Bug 1342343 Opened 3 years ago Closed 2 years ago
[meta]First round Display
The following are the display items found in wikipedia page. https://en.wikipedia.org/wiki/SHA-1 Use this bug to track these displayitem conversion and the rendering correctness. [DisplayItems] AltFeedback Background BackgroundColor Border Bullet ButtonBorderBackground ButtonForeground CanvasBackgroundColor ColumnRule Image TableBorderBackground Text ThemedBackground nsDisplaySVGGeometry
Is this the right wiki link?
(In reply to Mason Chang [:mchang] from comment #1) > Is this the right wiki link? We just randomly pick SHA-1 because there was a first sha1 collision. Do you have other link? We can check and add additional new displayitems.
Flags: needinfo?(howareyou322) → needinfo?(mchang)
Ahh sorry, I misread the first sentence. I thought it was a link to a wikipage of display items, not the test page. NM, thanks!
See https://bugzilla.mozilla.org/show_bug.cgi?id=1344002#c2 for items that don't need any conversion. Just dropping this in here as a PSA.
Just a note. After the works for wiki page are done, we can take a look about https://www.nytimes.com/.
I update what we still need for the first round display item conversion. Bug 1345388 - Add webrender support for AltFeedback Bug 1344079 - Add webrender support for ColumnRule Bug 1341101 - Convert nsDisplayBackgroundImage gradients into WebRender DisplayItems Bug 1349497 - Always create layer for nsDisplayBackgroundColor Bug 1349500 - Add webrender support for BulletFrame path type Bug 1344082 - Add webrender support for TableBorderBackground After these conversion, the next step should be correctness. Currently we create a preference for each type and most of the prefs are disabled by default. We should try to enable these prefs by default, which means we need to make the try result green. There are some related bugs: Bug 1346540 - Turn on 'layers.advanced.border-layers' by default Bug 1347727 - Enable outer box shadows by default in WR Bug 1348755 - Turn on 'layers.advanced.outline-layers' by default Bug 1350182 - Enable button border display items by default Bug 1349843 - Enable inset box shadows by default
After the conversion part in comment 6 are done, let's put our focus on the correctness part. If you fire a bug related to correctness, please add 'correctness' keyword on the bug. Here is the bug list about the correctness status. https://bugzilla.mozilla.org/buglist.cgi?keywords=correctness%2C%20&keywords_type=anywords&f1=blocked&list_id=13509612&o1=equals&resolution=---&chfieldto=Now&chfield=assigned_to&query_format=advanced&v1=1342343
Note: please keep the status of DI up to date in this etherpad: https://public.etherpad-mozilla.org/p/wr-status
3 years ago
Priority: -- → P3
3 years ago
Depends on: 1368120
2 years ago
The only remaining open blocker of this bug is the AltFeedback display item, which is marked as "IGNORE" in the DI etherpad linked above. So maybe we can close this bug now?
Yes, we can close this bug.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.