1337378 - [DateTimePicker] No indicator for today in date picker

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170207030214

[Affected versions]:
Nightly 54.0a1

[Affected platforms]:
All platforms: Ubuntu 16.04, Mac OS X 10.11, Windows 10

[Steps to reproduce]:
1.Launch Nightly 54.0a1 with a new profile
2.Set "dom.forms.datetime" and "dom.forms.datetime.timepicker" pref to True in about:config
3.In the URL bar enter "data:text/html, <input type="time">"
4.Click on the input box to trigger picker

[Expected result]:
Date picker should be opened. Today date should have a grey background.

[Actual result]:
Date picker is opened. Today date has no background.

Comment 1

[roxleitan]

Updates to third STR from above:
3.In the URL bar enter "data:text/html, <input type="date">"

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
after july we will have scott back to fix this.

Comment 3

[Scott Wu [:scottwu]]

Attachment: Bug 1337378 - Show today indicator on datetime picker calendar.

Review commit: https://reviewboard.mozilla.org/r/157656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157656/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886915 [details]
Bug 1337378 - Show today indicator on datetime picker calendar.

https://reviewboard.mozilla.org/r/157656/#review162968

::: toolkit/themes/shared/datetimeinputpickers.css:361
(Diff revision 1)
>    border: var(--border);
>    content: "";
>  }
>  
> +.calendar-container .days-view > div.today::before {
> +  background: var(--today-fill-color);

Why can't we just set the background on the div.today directly?

Comment 5

[Scott Wu [:scottwu]]

Attachment: Entire block vs rounded rectangle

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8886915 [details]
Bug 1337378 - Show today indicator on datetime picker calendar.

https://reviewboard.mozilla.org/r/157656/#review162968

> Why can't we just set the background on the div.today directly?

That's what I tried first but it would fill the entire block, rather than filling a rounded rectangular box: https://bugzilla.mozilla.org/attachment.cgi?id=8887316

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8886915 [details]
Bug 1337378 - Show today indicator on datetime picker calendar.

https://reviewboard.mozilla.org/r/157656/#review163766

Unfortunately, I can't test this - when I follow the STR, I get this in the popup:

http://imgur.com/qz1R4tZ

Comment 8

[Scott Wu [:scottwu]]

Comment on attachment 8886915 [details]
Bug 1337378 - Show today indicator on datetime picker calendar.

https://reviewboard.mozilla.org/r/157656/#review163766

Oh! The STR is wrong and it should be `data:text/html,<input type="date">` as noted in comment 1. It appears I broke the time picker in bug 1363672.. Will fix it in another bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cebef9d84892
Show today indicator on datetime picker calendar. r=mconley

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cebef9d84892

Comment 11

[Gerry Chang [:gchang]]

We are about to go to 55 RC. Mark 55 won't fix.

Comment 12

[roxleitan]

Verified as fixed on latest Nightly 56.0a1 (2017-07-31) on Windows 10 x64, Mac OS X 10.12 and Ubuntu 16.04 x64.