1337432 - browser_new_content_window_chromeflags.js should be updated to account for renamed CHROME_SUPPRESS_ANIMATION flag

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This fix landed in bug 1336230, but the test wasn't updated to account for the new flag. Strangely, the test didn't fail, so we should probably make sure that happens next time one of these flags changes names.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1337432 - browser_new_content_window_chromeflags.js should test the new CHROME_SUPPRESS_ANIMATION flag.

Before bug 1336230 landed, we were successfully testing the CHROME_MAC_SUPPRESS_ANIMATION
flag. Then we renamed the flag to CHROME_SUPPRESS_ANIMATION, but didn't update the test.

The test continued to pass though, since we ended up doing bitwise AND on undefined,
which produced the 0 value that the test expected.

This patch makes sure that the flag is non-zero-ish before doing the bitwise
operation. It also updates the flag to be CHROME_SUPPRESS_ANIMATION.

Review commit: https://reviewboard.mozilla.org/r/110402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110402/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8834474 [details]
Bug 1337432 - browser_new_content_window_chromeflags.js should test the new CHROME_SUPPRESS_ANIMATION flag.

https://reviewboard.mozilla.org/r/110402/#review111626

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ea5c21eb4c5
browser_new_content_window_chromeflags.js should test the new CHROME_SUPPRESS_ANIMATION flag. r=jaws

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ea5c21eb4c5