Closed Bug 1337467 Opened 3 years ago Closed 3 years ago

Convert observers to bundle events

Categories

(GeckoView :: General, defect)

All
Android
defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(22 files)

4.87 KB, patch
rbarker
: review+
Details | Diff | Splinter Review
4.28 KB, patch
rbarker
: review+
Details | Diff | Splinter Review
6.30 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
4.76 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
21.12 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
20.05 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
9.17 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
5.35 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
31.26 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
5.88 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
6.82 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
8.30 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
8.97 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
4.84 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
8.20 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
6.35 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
9.22 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
18.15 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
945 bytes, patch
jchen
: review+
Details | Diff | Splinter Review
5.92 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
10.27 KB, patch
sebastian
: review+
Details | Diff | Splinter Review
177.47 KB, patch
jchen
: review+
Details | Diff | Splinter Review
No description provided.
Also remove notifyCheckUpdateResult from GeckoInterface.
Attachment #8834525 - Flags: review?(s.kaspari)
Attachment #8834523 - Flags: review?(rbarker) → review+
Attachment #8834524 - Flags: review?(rbarker) → review+
Attachment #8834525 - Flags: review?(s.kaspari) → review+
Attachment #8834526 - Flags: review?(s.kaspari) → review+
Attachment #8834527 - Flags: review?(s.kaspari) → review+
Attachment #8834528 - Flags: review?(s.kaspari) → review+
Attachment #8834529 - Flags: review?(s.kaspari) → review+
Attachment #8834530 - Flags: review?(s.kaspari) → review+
Attachment #8835201 - Flags: review?(s.kaspari) → review+
Attachment #8835202 - Flags: review?(s.kaspari) → review+
Attachment #8835203 - Flags: review?(s.kaspari) → review+
Attachment #8835204 - Flags: review?(s.kaspari) → review+
Attachment #8835882 - Flags: review?(s.kaspari) → review+
Attachment #8835883 - Flags: review?(s.kaspari) → review+
Attachment #8835884 - Flags: review?(s.kaspari) → review+
Attachment #8835885 - Flags: review?(s.kaspari) → review+
The "Session:NotifyLocationChange" observer is sent by browser.js and
requires passing a browser reference, so it's left as an observer.
Attachment #8841755 - Flags: review?(s.kaspari)
Attachment #8841754 - Flags: review?(s.kaspari) → review+
Attachment #8841755 - Flags: review?(s.kaspari) → review+
Attachment #8841757 - Flags: review?(s.kaspari) → review+
Attachment #8841758 - Flags: review?(s.kaspari) → review+
Bug 1337467 - 1. Convert "Window:Resize" observer to event; r=rbarker

Bug 1337467 - 2. Convert "ScrollTo:FocusedInput" observer to event; r=rbarker

Bug 1337467 - 3. Convert "Update:CheckResult" observer to event; r=sebastian

Also remove notifyCheckUpdateResult from GeckoInterface.

Bug 1337467 - 4. Convert "GeckoView:ImportScript" observer to event; r=sebastian

Bug 1337467 - 5. Convert accessibility observers to events; r=sebastian

Bug 1337467 - 6. Convert media/casting observers to events; r=sebastian

Bug 1337467 - 7. Convert "Sanitize:ClearData" observer to event; r=sebastian

Bug 1337467 - 8. Convert "Notification:Event" observer to event; r=sebastian

Bug 1337467 - 9. Convert BrowserApp observers to events; r=sebastian

Bug 1337467 - 10. Convert Tab observers to events; r=sebastian

Bug 1337467 - 11. Convert "Passwords:Init" and "FormHistory:Init" observers to events; r=sebastian

Bug 1337467 - 12. Convert Reader observers to events; r=sebastian

Bug 1337467 - 13. Convert Distribution observers to events; r=sebastian

Bug 1337467 - 14. Convert "Fonts:Reload" observer to event; r=sebastian

Bug 1337467 - 15. Convert RecentTabsAdapter observers to events; r=sebastian

Bug 1337467 - 16. Convert "Session:Prefetch" observer to event; r=sebastian

Bug 1337467 - 17. Convert "Browser:Quit" and "FullScreen:Exit" observers to events; r=sebastian

Bug 1337467 - 18. Convert SessionStore observers to events; r=sebastian

The "Session:NotifyLocationChange" observer is sent by browser.js and
requires passing a browser reference, so it's left as an observer.

Bug 1337467 - 19. Remove unused "Tab:Screenshot:Cancel" notifyObserver call; r=me

Bug 1337467 - 20. Convert "Session:Navigate" observer to event; r=sebastian

Bug 1337467 - 21. Convert "Locale:*" observers to events; r=sebastian

Bug 1337467 - Add log for unhandled events; r=me

Add back the log indicating no listener for an event, which can be
useful when reading logcat. r=me for trivial change.

Bug 1337467 - Don't return error from EventDispatcher when OnEvent fails; r=me

When a listener's OnEvent method returns an error, continue to dispatch
to other listeners and don't return an error from the dispatch function.
This avoids unexpected errors when dispatching events. r=me for trivial
patch.
Attachment #8844534 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8098ab33c1b6
Convert observers to bundle events; r=rbarker r=sebastian
https://hg.mozilla.org/mozilla-central/rev/8098ab33c1b6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1346019
Depends on: 1346942
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.