1337467 - Convert observers to bundle events

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Convert "Window:Resize" observer to event (v1)

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Convert "ScrollTo:FocusedInput" observer to event (v1)

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Convert "Update:CheckResult" observer to event (v1)

Also remove notifyCheckUpdateResult from GeckoInterface.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Convert "GeckoView:ImportScript" observer to event (v1)

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Convert accessibility observers to events (v1)

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 6. Convert media/casting observers to events (v1)

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 7. Convert "Sanitize:ClearData" observer to event (v1)

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 8. Convert "Notification:Event" observer to event (v1)

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 9. Convert BrowserApp observers to events (v1)

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 10. Convert Tab observers to events (v1)

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 11. Convert "Passwords:Init" and "FormHistory:Init" observers to events (v1)

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 12. Convert Reader observers to events (v1)

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 13. Convert Distribution observers to events (v1)

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 14. Convert "Fonts:Reload" observer to event (v1)

Comment 15

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 15. Convert RecentTabsAdapter observers to events (v1)

Comment 16

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 16. Convert "Session:Prefetch" observer to event (v1)

Comment 17

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 17. Convert "Browser:Quit" and "FullScreen:Exit" observers to events (v1)

Comment 18

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 18. Convert SessionStore observers to events (v1)

The "Session:NotifyLocationChange" observer is sent by browser.js and
requires passing a browser reference, so it's left as an observer.

Comment 19

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 19. Remove unused "Tab:Screenshot:Cancel" notifyObserver call (v1)

Comment 20

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 20. Convert "Session:Navigate" observer to event (v1)

Comment 21

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 21. Convert "Locale:*" observers to events (v1)

Comment 22

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Combined patch (v1)

Bug 1337467 - 1. Convert "Window:Resize" observer to event; r=rbarker

Bug 1337467 - 2. Convert "ScrollTo:FocusedInput" observer to event; r=rbarker

Bug 1337467 - 3. Convert "Update:CheckResult" observer to event; r=sebastian

Also remove notifyCheckUpdateResult from GeckoInterface.

Bug 1337467 - 4. Convert "GeckoView:ImportScript" observer to event; r=sebastian

Bug 1337467 - 5. Convert accessibility observers to events; r=sebastian

Bug 1337467 - 6. Convert media/casting observers to events; r=sebastian

Bug 1337467 - 7. Convert "Sanitize:ClearData" observer to event; r=sebastian

Bug 1337467 - 8. Convert "Notification:Event" observer to event; r=sebastian

Bug 1337467 - 9. Convert BrowserApp observers to events; r=sebastian

Bug 1337467 - 10. Convert Tab observers to events; r=sebastian

Bug 1337467 - 11. Convert "Passwords:Init" and "FormHistory:Init" observers to events; r=sebastian

Bug 1337467 - 12. Convert Reader observers to events; r=sebastian

Bug 1337467 - 13. Convert Distribution observers to events; r=sebastian

Bug 1337467 - 14. Convert "Fonts:Reload" observer to event; r=sebastian

Bug 1337467 - 15. Convert RecentTabsAdapter observers to events; r=sebastian

Bug 1337467 - 16. Convert "Session:Prefetch" observer to event; r=sebastian

Bug 1337467 - 17. Convert "Browser:Quit" and "FullScreen:Exit" observers to events; r=sebastian

Bug 1337467 - 18. Convert SessionStore observers to events; r=sebastian

The "Session:NotifyLocationChange" observer is sent by browser.js and
requires passing a browser reference, so it's left as an observer.

Bug 1337467 - 19. Remove unused "Tab:Screenshot:Cancel" notifyObserver call; r=me

Bug 1337467 - 20. Convert "Session:Navigate" observer to event; r=sebastian

Bug 1337467 - 21. Convert "Locale:*" observers to events; r=sebastian

Bug 1337467 - Add log for unhandled events; r=me

Add back the log indicating no listener for an event, which can be
useful when reading logcat. r=me for trivial change.

Bug 1337467 - Don't return error from EventDispatcher when OnEvent fails; r=me

When a listener's OnEvent method returns an error, continue to dispatch
to other listeners and don't return an error from the dispatch function.
This avoids unexpected errors when dispatching events. r=me for trivial
patch.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8098ab33c1b6
Convert observers to bundle events; r=rbarker r=sebastian

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8098ab33c1b6