1345967 - Stuck about:firefox stuck at 'Looking for updates…' even after notification that new update is available

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android 55.0a1 20170308 and 20170309 on Sony Xperia Z3C (Android 6.0.1)

With Firefox set to never automatically download updates, opening about:firefox and checking for updates lets the button get stuck at 'Looking for updates…' even after a notification that a new update is available got added in the notification tray.

Comment 1

[Bill Gianopoulos [:WG9s]]

I am seeing the same symptoms trying to update from 20170310.  No idea if this was triggered by a change in the client or a failure in the update infrastructure, but even if it is the latter, it shoudl never result in just hanging forever at checking for updates.  There is definitely and update client issue here.

Comment 2

[Bill Gianopoulos [:WG9s]]

Actually this is probably even worse than I thought.  Batteries draining at an alarming rate.  I suspect the automatic check for updates is also hanging resulting in excessive battery drain.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is a regression from bug 1337467. The debugger reveals that |listener| at https://hg.mozilla.org/mozilla-central/rev/8098ab33c1b6#l33.36 gets optimized away, so that statement fails and |showUpdateMessage| doesn't get called. Please also fix the indentation for the block.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use global EventDispatcher for update messaging (v1)

Use the global EventDispatcher for signaling update results. The event
listener in about.js must be unregistered after every event to prevent
memory leaks, so expectUpdateResult() is added and called whenever we
are expecting update results.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf42045e783
Use global EventDispatcher for update messaging; r=sebastian

Comment 7

[Bill Gianopoulos [:WG9s]]

What are the chances of getting this merged before tomorrows mozilla-central nightly?  This has really been going on long enough, just my opinion, I could be wrong!

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3cf42045e783

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 55.0a1 2017-03-20 to 2017-03-21;
Device: HTC 10 (Android 6.0.1).