1337480 - test_417228-other-roots.js - excludedItemsFromRestore / excludedItems are undefined

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Mark Banner (:standard8)]

In trying to turn on the no-undef rule for eslint, I've come across test_417228-other-roots.js which has some undefined variables:

https://dxr.mozilla.org/mozilla-central/rev/af8a2573d0f1e9cc6f2ba0ab67d7a702a197f177/toolkit/components/places/tests/bookmarks/test_417228-other-roots.js#138
```
    if (aTest.excludedItemsFromRestore)
      excludedItemsFromRestore = excludedItems.concat(aTest.excludedItemsFromRestore);
```

`excludedItemsFromRestore` used to be defined as an array. However, it wasn't used, and `excludedItems` is also undefined.

This seems to have been the case since the test was originally landed.

I don't have enough knowledge here to know if this is something that needs fixing, or if we can just remove the code that has the undefined variables.

Marco - any ideas?

Comment 1

[Marco Bonardo [:mak]]

You can remove excludeItemsFromRestore, excludedItemsFromRestore and excludedItems.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1337480 - Remove undefined variables in test_417228-other-roots.js as they aren't needed.

Review commit: https://reviewboard.mozilla.org/r/110814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110814/

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8835121 [details]
Bug 1337480 - Remove undefined variables in test_417228-other-roots.js as they aren't needed.

https://reviewboard.mozilla.org/r/110814/#review112296

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82cdda27190e
Remove undefined variables in test_417228-other-roots.js as they aren't needed. r=mak

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82cdda27190e