1337625 - Make webrender as to use GLContext functions

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect, P3)

Description

[Sotaro Ikeda [:sotaro]]

get_proc_address_from_glcontext() returns a function pointer of GLContext::LookupSymbol(). It bypasses GLContext's several workaround for specific GPUs. It is not good.

Comment 1

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> get_proc_address_from_glcontext() returns a function pointer of
> GLContext::LookupSymbol(). It bypasses GLContext's several workaround for
> specific GPUs. It is not good.

It is also a request of :jgilbert.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

My first thought here is to create a map from string -> function pointer, where the string is GL function name that webrender is trying to look up, and the function pointer is one of the "GL official entry points" wrapper functions in GLContext.h. Is there a better way to do this?

Comment 3

[Sotaro Ikeda [:sotaro]]

I also thought similar things at first. But now, I tend to implement gl::Gl[1] trait at webrender_bindings. And the trait implementation directly calls functions of GLContext.h.

 - [1] https://github.com/servo/gleam/pull/106

Comment 4

[Sotaro Ikeda [:sotaro]]

Reopen it when this becomes actually necessary.