1323612 - Build webrender on android

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

We need to make graphic branch works on android

Comment 1

[Sotaro Ikeda [:sotaro]]

For now, we need to set Android NDK's API leven to 18. Since WebRender requests OpenGL ES 3.0 on android and it is supported since api level 18 on android.

Comment 2

[Sotaro Ikeda [:sotaro]]

android build requests rust librarys of armv7-linux-androideabi. Without them, "./mach build" emitted the following error.

----------------------------------------------------------------------

 0:00.80 DEBUG: Executing: `/usr/local/bin/rustc --crate-type staticlib --target=armv7-linux-androideabi -o /tmp/conftestsC6uc0.rlib /tmp/conftestym0zSN.rs`
 0:00.80 DEBUG: The command returned non-zero exit status 101.
 0:00.80 DEBUG: Its error output was:
 0:00.80 DEBUG: | error[E0463]: can't find crate for `std`
 0:00.80 DEBUG: |   |
 0:00.80 DEBUG: |   = note: the `armv7-linux-androideabi` target may not be installed
 0:00.80 DEBUG: |
 0:00.80 DEBUG: | error: aborting due to previous error
 0:00.80 DEBUG: |
 0:00.80 ERROR: Cannot compile for arm-unknown-linux-androideabi with /usr/local/bin/rustc
 0:00.80 The target may be unsupported, or you may not have

Comment 3

[Sotaro Ikeda [:sotaro]]

I did not know the official place to download the librarys of armv7-linux-androideabi. Then I referred servo build. bootstrap_commands.py[1] did download of pre-built compiler and prebuilt libraries. I manually downloaded the library from [2].

[1] https://dxr.mozilla.org/servo/source/python/servo/bootstrap_commands.py

[2] https://static-rust-lang-org.s3.amazonaws.com/dist/2016-11-29/rust-std-nightly-armv7-linux-androideabi.tar.gz

Comment 4

[Sotaro Ikeda [:sotaro]]

I used the following mozconfig to build on android

--------------------------------------------------

# Build Firefox for Android:
ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi

# With the following Android SDK and NDK:
ac_add_options --with-android-sdk="/absolute/path/to/android-sdk"
ac_add_options --with-android-ndk="/absolute/path/to/android-ndk-r11b" 

ac_add_options --with-android-version="18"
ac_add_options --enable-rust
ac_add_options --enable-webrender

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Fixed start up freeze. But gecko rendering result was not shown.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Output webrender composition result. Some gl calls seems to work, but image rendering of webrender did not work well. The symptom seems same to Bug 1323316 Comment 1.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Addressed profiler's glyph rendering. Image rendering still did not work.

Comment 12

[Sotaro Ikeda [:sotaro]]

During checking I noticed that gl::RED works on ANGLE on windows as GL_FORMAT_A, but gl::RED did not work on my nexus5X(arm). It might be a reason why GL_FORMAT_BGRA is used for ImageFormat::A8.

Comment 13

[Sotaro Ikeda [:sotaro]]

https://github.com/servo/webrender/issues/661

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Rebased. Rendering result and problems were same, but oom crash happened more easy.

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 16

[Sotaro Ikeda [:sotaro]]

FFI is broken on android, bug 1332737 is going to address it.

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #16)
> FFI is broken on android, bug 1332737 is going to address it.

It causes crash.

Comment 18

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 19

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 20

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 21

[Sotaro Ikeda [:sotaro]]

With https://github.com/servo/webrender/pull/791, I confirmed rendering on android device.

Comment 22

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 23

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Comment 24

[Sotaro Ikeda [:sotaro]]

With attachment 8831127 [details] [diff] [review], content is rendered, but scroll and touch did not work since APZ is not implemented yet.

Comment 25

[Sotaro Ikeda [:sotaro]]

:kats, is it possible to enable touch without apz? Touch did not work, but I could check the navigation by bluetooth keyboard.

Comment 26

[Kartikaya Gupta (email:[e-mail])]

Not really, we don't have any main-thread touch scrolling code. I can probably hack something up to add to the fennec browser.js if you really want.

Comment 27

[Kartikaya Gupta (email:[e-mail])]

Attachment: very slightly tested scrolling patch

This is what i had in mind. I'm doing a regular fennec build now to see if it works.

Comment 28

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8831152 [details] [diff] [review]
very slightly tested scrolling patch

I tried this patch in a regular firefox for android build and it seemed to do what I expected. So I think it should give you some basic ability to scroll in a webrender android build as well. I don't know if you'll be able to tap on links though, probably not.

Comment 29

[Sotaro Ikeda [:sotaro]]

Thanks!

Comment 30

[Sotaro Ikeda [:sotaro]]

attachment 8831152 [details] [diff] [review] and with some modifications to nsWindow, I also confirmed the scroll:-)

Comment 31

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

Add attachment 8831152 [details] [diff] [review] and change to nsWindow. Confirmed that main thread scroll works. Touch still do now work though.

Comment 32

[George Wright (:gw280) (needinfo me!)]

It's worth noting that for the time being you need the following in your mozconfig to build this:

ac_add_options --with-android-version=18
ac_add_options --enable-webrender

Comment 33

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Support webrender on Android

Comment 34

[Sotaro Ikeda [:sotaro]]

(In reply to George Wright (:gw280) (needinfo me!) from comment #32)
> It's worth noting that for the time being you need the following in your
> mozconfig to build this:
> 
> ac_add_options --with-android-version=18
> ac_add_options --enable-webrender

With attachment 8852425 [details] [diff] [review], we do not need "ac_add_options --with-android-version=18".

Comment 35

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Support webrender on Android

Comment 36

[Sotaro Ikeda [:sotaro]]

attachment 8854358 [details] [diff] [review] expects bug 1351480.

Comment 37

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8854358 [details] [diff] [review]
patch - Support webrender on Android

Review of attachment 8854358 [details] [diff] [review]:
-----------------------------------------------------------------

So I think we should split this into two. One patch just for the moz.configure change. That should get webrender building on Android. The rest of the changes are really runtime fixups for when webrender is enabled, and belong in another patch. And the moz.configure change should probably be reviewed by :froydnj or one of the other build peers.

::: gfx/layers/ipc/CompositorBridgeParent.cpp
@@ +711,5 @@
> +  if (!gfxVars::UseWebRender()) {
> +    if (mCompositor->Resume()) {
> +      resumed = true;
> +    }
> +  } else {

bool resumed = gfxVars::UseWebRender() ? mWrBridge->Resume() : mCompositor->Resume();

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +141,5 @@
>    MOZ_ASSERT(mApi);
>  
> +#ifdef MOZ_WIDGET_ANDROID
> +  // XXX temporal hack.
> +  // XXX Remove it when APZ is supproted.

s/temporal/temporary/
s/supproted/supported/

::: gfx/webrender_bindings/RendererOGL.cpp
@@ +139,5 @@
> +  }
> +  // RenewSurface internally calls MakeCurrent.
> +  return mGL->RenewSurface(mWidget);
> +#endif
> +  return true;

Change the #endif to an #else, and put an #endif at the end of the function body

Comment 38

[Sotaro Ikeda [:sotaro]]

Attachment: patch (Part 1) - Enable WebRender build on Android

Comment 39

[Sotaro Ikeda [:sotaro]]

Attachment: patch (Part 2) - Add runtime fixups for WebRender on Android

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/e6038d993d43
(Part 1) - Enable WebRender build on Android. r=froydnj
https://hg.mozilla.org/projects/graphics/rev/aa1f37911d77
(Part 2) - Add runtime fixups for WebRender on Android. r=kats

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/c5a346f39e07
Remove unused dependency in moz.configure rule. r=bustage

Comment 42

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/e6038d993d43
https://hg.mozilla.org/mozilla-central/rev/aa1f37911d77

Comment 43

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/c5a346f39e07