Closed
Bug 1337679
Opened 8 years ago
Closed 8 years ago
stylo: disable currently crashing xpcshell tests
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently we have a few xpcshell tests disabled in stylo, but the disabling is only done in the incubator/stylo repo. We should move this disabling annotations to mozilla-central. This patch does that, and adds a couple more test disablings that are needed for the latest mozilla-central merge.
Bug 1337667 is for fixing these.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8834784 -
Attachment is patch: true
|
||
Updated•8 years ago
|
Attachment #8834784 -
Flags: review?(bobbyholley) → review?(ted)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8834784 [details] [diff] [review]
patch
Review of attachment 8834784 [details] [diff] [review]:
-----------------------------------------------------------------
It would be nicer to use `expectedFailure`, but there's no built-in decorator to say "expect failure if this condition is true", which is unfortunate.
Thanks for filing a bug to track fixing them and mentioning it in the comment!
Attachment #8834784 -
Flags: review?(ted) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f600cc782bb
stylo: Disable currently crashing xpcshell tests; r=ted
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•