1337771 - Custom tabs: Action button not working for some apps

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Google+ adds a "Share" action button to custom tabs. Clicking it does not perform any action.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Same is true for Youtube. If a video has a link in the description then the custom tab will show a "Share" button but clicking it does not perform any action.

Comment 2

[Julian Chu [:walkingice]]

I cannot reproduce by Youtube App(ver 12.03.57). Everytime when I click link in description, it always opens a new normal tab in Fennec. (not by CustomTabIntent).

But I can reproduce by G+.

After inspection, invoke method `send` must give an additional intent as well. And set current URL ad data Uri to that intent. According to Android documentation[1], the method will copy information from additional-intent to original-intent if the information is missing.

I gonna to get current url to invoke `Intent.setData(Uri)`, is there any best practice to get the url?

[1] https://developer.android.com/reference/android/app/PendingIntent.html#send(android.content.Context,%20int,%20android.content.Intent)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Julian Chu [:walkingice] from comment #2)
> I cannot reproduce by Youtube App(ver 12.03.57). Everytime when I click link
> in description, it always opens a new normal tab in Fennec. (not by
> CustomTabIntent).

Interesting. Maybe they are running some kind of A/B experiment.

(In reply to Julian Chu [:walkingice] from comment #2)
> I gonna to get current url to invoke `Intent.setData(Uri)`, is there any
> best practice to get the url?

Tabs.getInstance().getSelectedTab().getURL() should give you the URL of the currently displayed website.

Comment 4

[Julian Chu [:walkingice]]

Attachment: Bug 1337771 - Let ActionButton works in some apps

If the intent from 3rd-party app doesn't have data url, directly call
PendingIntent.send() will perform nothing. To use current url as
polyfill to fix it.

Review commit: https://reviewboard.mozilla.org/r/111456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111456/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8835902 [details]
Bug 1337771 - Let ActionButton works in some apps

https://reviewboard.mozilla.org/r/111456/#review112770

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20d4be4ad46d
Let ActionButton works in some apps r=sebastian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20d4be4ad46d

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed in build 55.0a1 (2017-05-17) with devices: HTC Desire 820 (Android 6.0.1) and Nexus 9 (Android 7.1.1).
Tested on Google+, News&Weather, Chromer.