1337953 - Make nsDeque "a bit more" typesafe

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

nsDeque only deals with void* and forces callers to perform casts.
It should be trivial to make nsDeque templated on T* at zero extra cost, to provide just a bit more type safety and ease of use.

Some code will probably still explicitly use void*, and abuse that to store numbers. If it's easy enough to handle PODs, or even trivially-copyable types, I'll allow them; otherwise another bug can deal with it later on.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(Not enough time for this, de-assigning myself in case someone else wants to work on it.)

Comment 2

[Chris Fronk]

Attachment: Bug 1337953 - Make nsDeque templated on pointer type r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5614bcd268d1
Make nsDeque templated on pointer type r=froydnj

Comment 4

[Atila Butkovits]

Backed outfor bustage at FuzzyLayer.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe7c13be3ba5f011abd8fe9b0ad1a8176b3f7a93

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=5614bcd268d171373a1f20431110b81f1854a483&selectedTaskRun=QUFt3AfRT_eSxUK-tm6ofw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307213207&repo=autoland&lineNumber=17426

Comment 5

[Chris Fronk]

Submitting a new patch today re-based against latest https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e0d9768fbabf277a57c8ae2a522bb7c87d46598

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c8e1538b925
Make nsDeque templated on pointer type r=froydnj

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7c8e1538b925