Closed Bug 1337953 Opened 4 years ago Closed 3 months ago

Make nsDeque "a bit more" typesafe

Categories

(Core :: XPCOM, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: gerald, Assigned: fronkc1)

References

Details

Attachments

(1 file)

nsDeque only deals with void* and forces callers to perform casts.
It should be trivial to make nsDeque templated on T* at zero extra cost, to provide just a bit more type safety and ease of use.

Some code will probably still explicitly use void*, and abuse that to store numbers. If it's easy enough to handle PODs, or even trivially-copyable types, I'll allow them; otherwise another bug can deal with it later on.
Priority: -- → P3

(Not enough time for this, de-assigning myself in case someone else wants to work on it.)

Assignee: gsquelart → nobody
Assignee: nobody → fronkc1
Status: NEW → ASSIGNED
Blocks: 1647536
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5614bcd268d1
Make nsDeque templated on pointer type r=froydnj
Flags: needinfo?(fronkc1)
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c8e1538b925
Make nsDeque templated on pointer type r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.