Closed Bug 1647536 Opened 7 months ago Closed 5 months ago

Support for ref-counted pointers in nsDeque

Categories

(Core :: XPCOM, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: fronkc1, Assigned: fronkc1)

References

Details

Attachments

(1 file)

Suggested comment from bug1337953 to enhance nsDeque to support ref counted pointers. Currently many classes such as MediaQueue hack around this for storing ref counted pointers in nsDeque

Assignee: nobody → fronkc1
Status: NEW → ASSIGNED
Priority: -- → P4

Thank you for tackling this and making the code safer. 😀

Summary: Support for ref-counted pointers in nsDesque → Support for ref-counted pointers in nsDeque
Attachment #9165796 - Attachment description: Bug 1647536 - Support ref counted pointers in nsDeque → Bug 1647536 - Support ref counted pointers in nsDeque r=froydnj
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5838f8b581ed
Support ref counted pointers in nsDeque r=froydnj

Also seeing the following starting with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313038399&repo=autoland&lineNumber=2247
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313038926&repo=autoland&lineNumber=7455
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039256&repo=autoland&lineNumber=8242
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039366&repo=autoland&lineNumber=6702
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039393&repo=autoland&lineNumber=14544
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039593&repo=autoland&lineNumber=41864
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040680&repo=autoland&lineNumber=23135
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040404&repo=autoland&lineNumber=5669
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313041724&repo=autoland&lineNumber=1924
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313044656&repo=autoland&lineNumber=6969
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040398&repo=autoland&lineNumber=4797
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313044701&repo=autoland&lineNumber=3799
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313033447&repo=autoland&lineNumber=2106
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313037083&repo=autoland&lineNumber=8025
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313047581&repo=autoland&lineNumber=1405

Apologies the try job I ran must not have been extensive enough will look at the test failures and rework the patch to fix those

Flags: needinfo?(fronkc1)
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b82bd2da05ea
Support ref counted pointers in nsDeque r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.