1647536 - Support for ref-counted pointers in nsDeque

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P4)

Description

[Chris Fronk]

Suggested comment from bug1337953 to enhance nsDeque to support ref counted pointers. Currently many classes such as MediaQueue hack around this for storing ref counted pointers in nsDeque

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for tackling this and making the code safer. 😀

Comment 2

[Chris Fronk]

Attachment: Bug 1647536 - Support ref counted pointers in nsDeque r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5838f8b581ed
Support ref counted pointers in nsDeque r=froydnj

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 5838f8b581ed (Bug 1647536) for causing failures in browser_active_mediasession_among_tabs.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d2d8423bbd3a9e06efa16ab6c33392fd715761f3

Push with failures:

• gl1c failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=6b495a62f535331db380586854007bb2207a9675&searchStr=os%2Cx%2C10.14%2Copt%2Cmochitests%2Ctest-macosx1014-64%2Fopt-mochitest-webgl1-core-e10s%2Cgl1c&tochange=72ef55c14a4c2167a35254020b4c1192334f1913&selectedTaskRun=DevdNbh7QLaYeyb2WPAVCg.0

• https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=d1a5046cd6361036d121621b708b525d4ebf6cde&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s%2Cbc10&tochange=72ef55c14a4c2167a35254020b4c1192334f1913&selectedTaskRun=Diop0hLGQSaUAtj_fj0Osg.0

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313038745&repo=autoland&lineNumber=4392
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313032350&repo=autoland&lineNumber=9096

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Also seeing the following starting with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313038399&repo=autoland&lineNumber=2247
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313038926&repo=autoland&lineNumber=7455
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039256&repo=autoland&lineNumber=8242
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039366&repo=autoland&lineNumber=6702
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039393&repo=autoland&lineNumber=14544
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313039593&repo=autoland&lineNumber=41864
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040680&repo=autoland&lineNumber=23135
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040404&repo=autoland&lineNumber=5669
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313041724&repo=autoland&lineNumber=1924
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313044656&repo=autoland&lineNumber=6969
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313040398&repo=autoland&lineNumber=4797
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313044701&repo=autoland&lineNumber=3799
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313033447&repo=autoland&lineNumber=2106
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313037083&repo=autoland&lineNumber=8025
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313047581&repo=autoland&lineNumber=1405

Comment 6

[Chris Fronk]

Apologies the try job I ran must not have been extensive enough will look at the test failures and rework the patch to fix those

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b82bd2da05ea
Support ref counted pointers in nsDeque r=froydnj

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b82bd2da05ea