1338000 - error: no 'float webrtc::SincResampler::Convolve_NEON(const float*, const float*, const float*, double)' member function declared in class 'webrtc::SincResampler'

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mike Hommey [:glandium]]

On ARM Linux (non-Android), webrtc fails to build with:

23:39.44 In file included from /home/glandium/mozilla-central/obj-armv8l-unknown-linux-gnueabihf/media/webrtc/trunk/webrtc/common_audio/common_audio_common_audio_neon/Unified_cpp_webrtc_common_audio0.cpp:11:0:
23:39.44 /home/glandium/mozilla-central/media/webrtc/trunk/webrtc/common_audio/resampler/sinc_resampler_neon.cc:22:70: error: no 'float webrtc::SincResampler::Convolve_NEON(const float*, const float*, const float*, double)' member function declared in class 'webrtc::SincResampler'
23:39.44                                     double kernel_interpolation_factor) {

(don't mind the objdir name, the target is armhf, not arm64 ; the host is arm64, but the build is in a armhf chroot)

Presumably, the condition to set WEBRTC_DETECT_NEON in media/webrtc/trunk/webrtc/build/common.gypi is wrong.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)
> Presumably, the condition to set WEBRTC_DETECT_NEON in
> media/webrtc/trunk/webrtc/build/common.gypi is wrong.

confirmed.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1338000 - Fix webrtc build on non-Android ARM Linux.

Review commit: https://reviewboard.mozilla.org/r/110910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110910/

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8835212 [details]
Bug 1338000 - Fix webrtc build on non-Android ARM Linux.

https://reviewboard.mozilla.org/r/110910/#review112272

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62faa85b1926
Fix webrtc build on non-Android ARM Linux. r=jesup

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62faa85b1926

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8835212 [details]
Bug 1338000 - Fix webrtc build on non-Android ARM Linux.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1250356
[User impact if declined]: Failure to build on ARM Linux (non-Android)
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: verified locally
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Essentially, the patch doesn't change anything but for non-Android ARM builds.
[String changes made/needed]: N/A

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8835212 [details]
Bug 1338000 - Fix webrtc build on non-Android ARM Linux.

Fix for webrtc build, regression from 53, let's take this in aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e65e784125a