Closed Bug 1338195 Opened 3 years ago Closed 3 years ago

Fix no-undef warnings for addMessageListener/sendAsyncMessage & co

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

This fixes a bunch of warnings about addMessageListener & sendAsyncMessage.

As discussed with :Mossop on irc, we decided to mark these on each file individually.
Comment on attachment 8835563 [details]
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

Looking at further items today, I think we might want a different approach to this. Most of these are frame script related items.

Hence I think we could just have a flag for frame scripts which would include the relevant globals automatically.
Attachment #8835563 - Flags: review?(dtownsend)
I've just played around a bit more, and I think having a flag is definitely the better way to go.

Currently the patch I've got depends on bug 1338249, so once that lands, I'll clean it up and get it posted.
Depends on: 1338249
Comment on attachment 8835563 [details]
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

https://reviewboard.mozilla.org/r/111256/#review114636
Attachment #8835563 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04254c61603c
Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals. r=mossop
https://hg.mozilla.org/mozilla-central/rev/04254c61603c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.