1338195 - Fix no-undef warnings for addMessageListener/sendAsyncMessage & co

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mark Banner (:standard8)]

This fixes a bunch of warnings about addMessageListener & sendAsyncMessage.

As discussed with :Mossop on irc, we decided to mark these on each file individually.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

Review commit: https://reviewboard.mozilla.org/r/111256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111256/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8835563 [details]
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

Looking at further items today, I think we might want a different approach to this. Most of these are frame script related items.

Hence I think we could just have a flag for frame scripts which would include the relevant globals automatically.

Comment 3

[Mark Banner (:standard8)]

I've just played around a bit more, and I think having a flag is definitely the better way to go.

Currently the patch I've got depends on bug 1338249, so once that lands, I'll clean it up and get it posted.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8835563 [details]
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111256/diff/1-2/

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8835563 [details]
Bug 1338195 - Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals.

https://reviewboard.mozilla.org/r/111256/#review114636

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04254c61603c
Define a `frame-script` environment for eslint and use it to clear no-undef issues for known frame script globals. r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04254c61603c