1338255 - Remove remaining legacy generator from js/xpconnect/.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Tooru Fujisawa [:arai]]

remainder of bug 1321222

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove remaining legacy generator from js/xpconnect/tests/.

changed testBody to async function, and moved do_test_finished call to head_watchdog.js.
also removed continueTest by replacing the callsite to use promise.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8835789 [details] [diff] [review]
Remove remaining legacy generator from js/xpconnect/tests/.

Review of attachment 8835789 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/tests/unit/head_watchdog.js
@@ +99,5 @@
>  
>    // Run async.
>    do_test_pending();
>  
>    // Instantiate the generator and kick it off.

What generator?

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing :)

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #2)
> Comment on attachment 8835789 [details] [diff] [review]
> Remove remaining legacy generator from js/xpconnect/tests/.
> 
> Review of attachment 8835789 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/xpconnect/tests/unit/head_watchdog.js
> @@ +99,5 @@
> >  
> >    // Run async.
> >    do_test_pending();
> >  
> >    // Instantiate the generator and kick it off.
> 
> What generator?

good catch :)
replaced with "// Run the async function."

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc113a0cbbade1d134d55dc531b79f255da86348
Bug 1338255 - Remove remaining legacy generator from js/xpconnect/tests/. r=bholley

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc113a0cbbad