Closed Bug 1338320 Opened 3 years ago Closed 3 years ago

annotate testing/web-platform/moz.build with BUG_COMPONENT for tests/ directory

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

there are many directories of tests underneath testing/web-platform/tests/, we need to match these up to bugzilla-components to help find the right people to debug issues.
I have 8 questions on specific directories, otherwise I have mediacapture -> workers annotated.  upcoming questions/patch tomorrow.
:tnguyen, can you help me determine which bugzilla component bugs for these referrer-policy tests should go:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/referrer-policy

I suspect it would be a single component for all tests.
Flags: needinfo?(tnguyen)
Simon, could you help me figure out which bugzilla component bugs related to the preload tests would go in:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/preload

I suspect these will all fall in the same component.
Flags: needinfo?(zcorpan)
:ato, can you help me figure out what bugzilla component I would file bugs for old-tests/webdriver/*:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/old-tests/webdriver

would it be testing::marionette?
Flags: needinfo?(ato)
I still need to figure out:
testing/web-platform/tests/old-tests/submission/Infraware/Session_History/contents/Session_History/
testing/web-platform/tests/old-tests/submission/Opera/script_scheduling/
testing/web-platform/tests/old-tests/submission/Microsoft/foreigncontent
testing/web-platform/tests/old-tests/submission/Microsoft/sandbox
testing/web-platform/tests/old-tests/submission/Microsoft/structuredclones
testing/web-platform/tests/old-tests/submission/Microsoft/xhtml5
testing/web-platform/tests/page-visibility/
testing/web-platform/tests/payment-request/
testing/web-platform/tests/presentation-api/

open to any drive by comments on these as well.
(In reply to Joel Maher ( :jmaher) from comment #4)
> :ato, can you help me figure out what bugzilla component I would file bugs
> for old-tests/webdriver/*:
> https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/
> old-tests/webdriver
> 
> would it be testing::marionette?

They should be filed with the "webdriver" label on https://github.com/w3c/web-platform-tests/.
Flags: needinfo?(ato)
interesting, but I think it works:
 ./mach file-info bugzilla-component testing/web-platform/tests/webdriver/**
https://github.com/w3c/web-platform-tests/ :: webdriver
  testing/web-platform/tests/webdriver/OWNERS
  testing/web-platform/tests/webdriver/README.md
  testing/web-platform/tests/webdriver/actions.py
  testing/web-platform/tests/webdriver/contexts.py
  testing/web-platform/tests/webdriver/interface.html
  testing/web-platform/tests/webdriver/navigation.py
  testing/web-platform/tests/webdriver/support
(In reply to Joel Maher ( :jmaher) from comment #2)
> :tnguyen, can you help me determine which bugzilla component bugs for these
> referrer-policy tests should go:
> https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/
> referrer-policy
> 
> I suspect it would be a single component for all tests.

they are under dom:sercurity
Flags: needinfo?(tnguyen)
(In reply to Joel Maher ( :jmaher) from comment #3)
> Simon, could you help me figure out which bugzilla component bugs related to
> the preload tests would go in:
> https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/
> preload
> 
> I suspect these will all fall in the same component.

I don't know. James?
Flags: needinfo?(zcorpan) → needinfo?(james)
> testing/web-platform/tests/old-tests/submission/Infraware/Session_History/contents/Session_History/

Presumably either Core::History: Global or Core::DOM: Core & HTML

> testing/web-platform/tests/old-tests/submission/Opera/script_scheduling/

Core::DOM: Core & HTML

> testing/web-platform/tests/old-tests/submission/Microsoft/foreigncontent

Maybe Core::SVG (these tests look like junk anyway)

> testing/web-platform/tests/old-tests/submission/Microsoft/sandbox

Either Core::DOM: Security or Core::DOM: Core & HTML or Core::Security

> testing/web-platform/tests/old-tests/submission/Microsoft/structuredclones

Core::Javascript Engine

> testing/web-platform/tests/old-tests/submission/Microsoft/xhtml5

These tests are junk, but might become Core::Layout if they were fixed

> testing/web-platform/tests/page-visibility/

Core::DOM I think

> testing/web-platform/tests/payment-request/

Core::DOM

> testing/web-platform/tests/presentation-api/

Core::DOM
Flags: needinfo?(james)
> testing/web-platform/tests/preload

Core::DOM: Core & HTML 

> testing/web-platform/tests/old-tests/webdriver

testing::marionette is fine
:overholt, I am asking you for review  as much of these fall in Core::DOM, please feel free to redirect as you see fit.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8838115 - Flags: review?(overholt)
updated typedarrays to be Core::Javascript: Standard Library.
Attachment #8838115 - Attachment is obsolete: true
Attachment #8838115 - Flags: review?(overholt)
Attachment #8838486 - Flags: review?(overholt)
Comment on attachment 8838486 [details] [diff] [review]
add BUG_COMPONENT to testing/web-platform/tests/* (part 1 of 2)

Review of attachment 8838486 [details] [diff] [review]:
-----------------------------------------------------------------

With the changes below (above?), r=overholt. Sorry for the delay here!

::: testing/web-platform/moz.build
@@ +55,5 @@
> +with Files("tests/mixed-content/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Security")
> +
> +with Files("tests/navigation-timing/**"):
> +    BUG_COMPONENT = ("Core", "Document Navigation")

Just Core::DOM here.

@@ +58,5 @@
> +with Files("tests/navigation-timing/**"):
> +    BUG_COMPONENT = ("Core", "Document Navigation")
> +
> +with Files("tests/notifications/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Workers")

Toolkit::Notifications and Alerts

@@ +65,5 @@
> +    BUG_COMPONENT = ("Core", "Canvas: 2D")
> +
> +# No tests are run here
> +with Files("tests/old-tests/submission/Infraware/Session_History/**"):
> +    BUG_COMPONENT = ("Core", "History: Global")

Core::Document Navigation

@@ +71,5 @@
> +with Files("tests/old-tests/submission/Infraware/forms/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Core & Html")
> +
> +with Files("tests/old-tests/Opera/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Core & Html")

s/old-tests\/Opera/old-tests\/submission\/Opera/ . These are a real mix ... what do you want to do with them?

@@ +75,5 @@
> +    BUG_COMPONENT = ("Core", "DOM: Core & Html")
> +
> +# No tests are run here
> +with Files("tests/old-tests/Microsoft/dragdrop/**"):
> +    BUG_COMPONENT = ("Core", "Drag & Drop")

s/old-tests\/Microsoft/old-tests\/submission\/Microsoft/

@@ +82,5 @@
> +with Files("tests/old-tests/Microsoft/foreigncontent/**"):
> +    BUG_COMPONENT = ("Core", "SVG")
> +
> +with Files("tests/old-tests/Microsoft/history/**"):
> +    BUG_COMPONENT = ("Core", "History: Global")

Core::Document Navigation is more applicable, I think.

@@ +108,5 @@
> +with Files("tests/payment-request/**"):
> +    BUG_COMPONENT = ("Core", "DOM")
> +
> +with Files("tests/performance-timeline/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Service Workers")

Core::DOM

@@ +142,5 @@
> +    BUG_COMPONENT = ("Core", "DOM")
> +
> +with Files("tests/secure-contexts/**"):
> +    BUG_COMPONENT = ("Core", "DOM: Workers")
> +

While there are a bunch of worker things in this directory I think this is more "https" so let's just go with Core::DOM (we can always fix it or move bugs later).

@@ +171,5 @@
> +with Files("tests/svg-aam/**"):
> +    BUG_COMPONENT = ("Core", "SVG")
> +
> +with Files("tests/touchevents/**"):
> +    BUG_COMPONENT = ("Core", "Panning and Zooming")

Core::DOM

@@ +177,5 @@
> +with Files("tests/typedarrays/**"):
> +    BUG_COMPONENT = ("Core", "Javascript: Standard Library")
> +
> +with Files("tests/uievents/**"):
> +    BUG_COMPONENT = ("Core", "DOM")

Let's go with DOM: Events
Attachment #8838486 - Flags: review?(overholt) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d509e4b368
annotate testing/web-platform/moz.build with BUG_COMPONENT: part1. r=overholt
https://hg.mozilla.org/mozilla-central/rev/41d509e4b368
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
See Also: → 1349044
You need to log in before you can comment on or make changes to this bug.