133867 - document.write options do not show up in combobox

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[John Keiser (jkeiser)]

When you document.write() a selected option into a combobox, blank shows up in
the combobox instead.

Another bug already exists with an obviously poor summary; creating this bug to
hold the patch and get it through the review process.

Comment 1

[John Keiser (jkeiser)]

Attachment: Testcase

Comment 2

[John Keiser (jkeiser)]

Attachment: Patch

The problem is that when a textnode is added as a child of the option, the
combobox is not notified that the text of the option has changed.  This patch
fixes that, as well as a resultant recursion in the content sink.  (AppendChild
was called before parser state was eaten up, then BeginUpdate() got called from
the combobox, which flushed the text nodes again, and called AppendChild again
...)

Comment 3

[John Keiser (jkeiser)]

*** Bug 130837 has been marked as a duplicate of this bug. ***

Comment 4

[rods (gone)]

Comment on attachment 76508 [details] [diff] [review]
Patch

r=rods

Comment 5

[vidur (gone)]

Comment on attachment 76508 [details] [diff] [review]
Patch

sr=vidur. Glad to see the recursion problem caught. I'll buy that the fix
works.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 76508 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 7

[John Keiser (jkeiser)]

Fix checked in.

Comment 8

[Terri Preston]

Verified fixed linux trunk build 2002061808, Win XP trunk build 2002061808 and
Mac OS X trunk build 2002061808