1338862 - Permaorange in test_webgl_debug_renderer_info.html when Gecko 53 merges to beta on 2017-03-06

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Phil Ringnalda (:philor)]

Bug 1336645 removed preffing off webgl.enable-debug-renderer-info for RELEASE_OR_BETA, but https://hg.mozilla.org/mozilla-central/annotate/0eef1d5a39366059677c6d7944cfe8a97265a011/dom/canvas/test/chrome/test_webgl_debug_renderer_info.html#l27 hardcodes RELEASE_OR_BETA instead of either reading the pref, or just being removed now that the pref is on by default, so when aurora merges to beta in three weeks, it'll be permaorange.

Comment 1

[Phil Ringnalda (:philor)]

[Tracking Requested - why for this release]: permaorange on the merge to beta, closed trees, wailing and tearing of hair.

Comment 2

[Phil Ringnalda (:philor)]

Forgot the link to a log, https://treeherder.mozilla.org/logviewer.html#?job_id=76638515&repo=try, from the simulation push, https://treeherder.mozilla.org/#/jobs?repo=try&revision=46c3eb85b4687c968b6b89873d5f5a2f9fc89435, though I like the way skipping it makes it look like I just figured it out from reading the patch.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1338862 - Update tests for WEBGL_debug_renderer_info. -

Review commit: https://reviewboard.mozilla.org/r/112238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112238/

Comment 4

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d297e2e0c77e071ad30eef7a66cface6f8d5456&filter-searchStr=gpu - doesn't fail, but it does consistently time out with that patch.

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8836926 [details]
Bug 1338862 - Update tests for WEBGL_debug_renderer_info. -

https://reviewboard.mozilla.org/r/112238/#review113714

::: dom/canvas/test/chrome/test_webgl_debug_renderer_info.html
(Diff revision 1)
> -  iframe.onload = function () {
> -
> -    // test that chrome can get WEBGL_debug_renderer_info on a canvas on the iframe...
> -    // this is useful to check in itself, and is also useful so the subsequent non-chrome test
> -    // will also test that doing so doesn't confuse our chrome-only check.
> -    checkChromeCase(iframe.contentDocument.createElement("canvas"));

I don't understand why you remove the test for iframe. Can you explain it?

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8836926 [details]
Bug 1338862 - Update tests for WEBGL_debug_renderer_info. -

https://reviewboard.mozilla.org/r/112238/#review113714

> I don't understand why you remove the test for iframe. Can you explain it?

I removed the non-chrome test, since it's not a privileged extension anymore.
I think we should keep the chrome test to ensure that it's always available to chrome code though.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8836926 [details]
Bug 1338862 - Update tests for WEBGL_debug_renderer_info. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112238/diff/1-2/

Comment 8

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8836926 [details]
Bug 1338862 - Update tests for WEBGL_debug_renderer_info. -

https://reviewboard.mozilla.org/r/112238/#review114038

LGTM

Comment 9

[Kelsey Gilbert [:jgilbert]]

(In reply to Phil Ringnalda (:philor) from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=9d297e2e0c77e071ad30eef7a66cface6f8d5456&filter-
> searchStr=gpu - doesn't fail, but it does consistently time out with that
> patch.

Updated again. Can you retest?

Comment 10

[Phil Ringnalda (:philor)]

Look at all them green gpus in https://treeherder.mozilla.org/#/jobs?repo=try&revision=d139e05854056ed9177d1b91995cc03b4f07120b&group_state=expanded, just look at them!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5387e70bd9c5
Update tests for WEBGL_debug_renderer_info. - r=daoshengmu

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5387e70bd9c5

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53189303b53d