1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Review commit: https://reviewboard.mozilla.org/r/109782/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109782/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109782/diff/1-2/

Comment 3

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

https://reviewboard.mozilla.org/r/109782/#review110820

Comment 4

[Masatoshi Kimura [:emk]]

How privacy concerns are resolved? Or declared not resolved?

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> How privacy concerns are resolved? Or declared not resolved?

I'm not aware of any outstanding privacy concerns here. You'll have to be more specific.

Comment 6

[Masatoshi Kimura [:emk]]

More fingerprinting vector. I'm OK if we don't care fingerprinting anymore and punting problems into "privacy.resistFingerprinting" pref. But we should not pretend as if we have no privacy issue at all.

Comment 7

[Kelsey Gilbert [:jgilbert]]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> More fingerprinting vector. I'm OK if we don't care fingerprinting anymore
> and punting problems into "privacy.resistFingerprinting" pref. But we should
> not pretend as if we have no privacy issue at all.

Tracking this in bug 1337157.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Slow roll-out of a pref flip.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: It just flips a pref.
[String changes made/needed]: none

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaff9aacbf67
Roll out WEBGL_debug_renderer_info to Beta and Release. - r=mchang

Comment 10

[Julien Cristau [:jcristau]]

The uplift request doesn't explain why this should go to beta today as opposed to next cycle (when bugs 1171228/1175424 have been around for a couple of years), or why it should land without bug 1337157 :(

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aaff9aacbf67

Comment 12

[Kelsey Gilbert [:jgilbert]]

(In reply to Julien Cristau [:jcristau] from comment #10)
> The uplift request doesn't explain why this should go to beta today as
> opposed to next cycle (when bugs 1171228/1175424 have been around for a
> couple of years), or why it should land without bug 1337157 :(

Bug 1171228 wasn't meant to leave it #ifndef RELEASE forever, and the Intent to Ship email thread exposed no blockers to implementing this. Safari also rolled this out in the mean time.

Bug 1337157 is nice-to-have, since there are already prefs to spoof and/or disable this extension. They just aren't hooked up to the central pref.

Comment 13

[Kelsey Gilbert [:jgilbert]]

Since we're shipping this in 54, and since there's no reason to not roll out this pref-only change to 53 and 52, we should just take it there too.

Comment 14

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Well, let's bring it to aurora at least.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/63752d3df9fa

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8833559 [details]
Bug 1336645 - Roll out WEBGL_debug_renderer_info to Beta and Release. -

Seems to me this can go in 53.

Comment 17

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/53#WebGL
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_debug_renderer_info