1339144 - Use windowless remote <browser> element for background pages

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1287004 +++

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1339144 - Use windowless browser for remote background pages.

Review commit: https://reviewboard.mozilla.org/r/112838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112838/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8837837 [details]
Bug 1339144 - Use windowless browser for remote background pages.

https://reviewboard.mozilla.org/r/112838/#review114694

::: toolkit/components/extensions/ExtensionParent.jsm:731
(Diff revision 1)
>    createBrowserElement() {
>      if (this.browser) {
>        throw new Error("createBrowserElement called twice");
>      }
>  
> -    let waitForParentDocument;
> +    return this.createWindowlessBrowser().then(async chromeDoc => {

why not just make `createBrowserElement()` async and use await here instead of chaining?  the only visible difference I can see is that it would reject instead of throwing immediately if called twice...

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8837837 [details]
Bug 1339144 - Use windowless browser for remote background pages.

https://reviewboard.mozilla.org/r/112838/#review114694

> why not just make `createBrowserElement()` async and use await here instead of chaining?  the only visible difference I can see is that it would reject instead of throwing immediately if called twice...

Yeah, I thought about making it an async function, but decided not to for the sake of the error. But I guess it really doesn't matter whether it throws an error or rejects.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba94924e6d7959f5d8850e6ab14008d4a1c6288
Bug 1339144 - Use windowless browser for remote background pages. r=aswan

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I backed this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=78116805&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/6761a1a2c723

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c122b0183c7c94342c7bac953987ca1ed9c94625
Bug 1339144 - Use windowless browser for remote background pages. r=aswan

Comment 7

[Iris Hsiao [:ihsiao]]

sorry had to back this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=78133237&repo=mozilla-inbound&lineNumber=1965 and https://treeherder.mozilla.org/logviewer.html#?job_id=78133268&repo=mozilla-inbound&lineNumber=1633

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ebda0965b13

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c3d1b928cf814751ac91369d1703f4e0e90022
Bug 1339144 - Use windowless browser for remote background pages. r=aswan

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5c3d1b928cf