Closed
Bug 1339144
Opened 7 years ago
Closed 7 years ago
Use windowless remote <browser> element for background pages
Categories
(WebExtensions :: General, defect, P1)
WebExtensions
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
(Whiteboard: triaged)
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1287004 +++
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8837837 [details] Bug 1339144 - Use windowless browser for remote background pages. https://reviewboard.mozilla.org/r/112838/#review114694 ::: toolkit/components/extensions/ExtensionParent.jsm:731 (Diff revision 1) > createBrowserElement() { > if (this.browser) { > throw new Error("createBrowserElement called twice"); > } > > - let waitForParentDocument; > + return this.createWindowlessBrowser().then(async chromeDoc => { why not just make `createBrowserElement()` async and use await here instead of chaining? the only visible difference I can see is that it would reject instead of throwing immediately if called twice...
Attachment #8837837 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8837837 [details] Bug 1339144 - Use windowless browser for remote background pages. https://reviewboard.mozilla.org/r/112838/#review114694 > why not just make `createBrowserElement()` async and use await here instead of chaining? the only visible difference I can see is that it would reject instead of throwing immediately if called twice... Yeah, I thought about making it an async function, but decided not to for the sake of the error. But I guess it really doesn't matter whether it throws an error or rejects.
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba94924e6d7959f5d8850e6ab14008d4a1c6288 Bug 1339144 - Use windowless browser for remote background pages. r=aswan
I backed this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=78116805&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/6761a1a2c723
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c122b0183c7c94342c7bac953987ca1ed9c94625 Bug 1339144 - Use windowless browser for remote background pages. r=aswan
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo)
Comment 7•7 years ago
|
||
sorry had to back this out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=78133237&repo=mozilla-inbound&lineNumber=1965 and https://treeherder.mozilla.org/logviewer.html#?job_id=78133268&repo=mozilla-inbound&lineNumber=1633 https://hg.mozilla.org/integration/mozilla-inbound/rev/0ebda0965b13
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c3d1b928cf814751ac91369d1703f4e0e90022 Bug 1339144 - Use windowless browser for remote background pages. r=aswan
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e5c3d1b928cf
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo)
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•