1339244 - Code to set the minimum bitrate estimate to Try runs in webrtc was lost in the 49 update

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

This causes tests, especially bitrate-dependent tests like test_peerConnection_simulcastOffer.html to become very flakey.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: add minimum bandwidth estimate support back in; lost in bug 1250356

MozReview-Commit-ID: HCBsaoClerh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cc682f59b6a
add minimum bandwidth estimate support back in; lost in bug 1250356 r=ng

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cc682f59b6a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8836900 [details] [diff] [review]
add minimum bandwidth estimate support back in; lost in bug 1250356

Approval Request Comment
[Feature/Bug causing the regression]: webrtc.org 49 landing

[User impact if declined]: test flakinesss

[Is this code covered by automated tests?]: yes

[Has the fix been verified in Nightly?]: yes

[Needs manual test from QE? If yes, steps to reproduce]: no

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: simple change only when about:config pref is set

[String changes made/needed]: none

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8836900 [details] [diff] [review]
add minimum bandwidth estimate support back in; lost in bug 1250356

Fix for testing in try, let's uplift this to aurora before 53 goes to beta.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1122e037842c