1339540 - Add a separate nsresult module for ErrorResult to use

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

There are some nsresult values that mean special things to ErrorResult.  We should make them clearly ErrorResult-specific.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Introduce an ErrorResult-specific nsresult module

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Move the three ErrorResult-internal NS_ERROR_DOM_* values over to the ErrorResult error module

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Use nsresult values in the ErrorResult error module in place of NS_ERROR_TYPE_ERR/NS_ERROR_RANGE_ERR in ErrorResult code

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Use nsresult values in the ErrorResult error module in place of NS_ERROR_TYPE_ERR/NS_ERROR_RANGE_ERR in ErrorResult code

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8837262 [details] [diff] [review]
part 2.  Move the three ErrorResult-internal NS_ERROR_DOM_* values over to the ErrorResult error module

+  /* Represents an JS Value being thrown as an exception. */
Should it be 'a JS'?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8837266 [details] [diff] [review]
part 3.  Use nsresult values in the ErrorResult error module in place of NS_ERROR_TYPE_ERR/NS_ERROR_RANGE_ERR in ErrorResult code

ok, so old NS_ERROR_TYPE_ERR and NS_ERROR_RANGE_ERR are still there.
I guess their usage should be replaced with ThrowTypeError and ThrowRangeError, but that is a separate bug or bugs?

Comment 7

[Boris Zbarsky [:bzbarsky]]

> Should it be 'a JS'?

Yes.  Fixed.

> ok, so old NS_ERROR_TYPE_ERR and NS_ERROR_RANGE_ERR are still there.

Yes.  They sort of predate ErrorResult using them, so...

> I guess their usage should be replaced with ThrowTypeError and ThrowRangeError

Probably, yes.  And yes, that's separate bug fodder.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ebb182ab1da2
https://hg.mozilla.org/mozilla-central/rev/8682efc34f6c
https://hg.mozilla.org/mozilla-central/rev/b17eeee93d22