Closed Bug 1339540 Opened 3 years ago Closed 3 years ago

Add a separate nsresult module for ErrorResult to use

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: sec-want, Whiteboard: [post-critsmash-triage][adv-main54-])

Attachments

(3 files, 1 obsolete file)

There are some nsresult values that mean special things to ErrorResult.  We should make them clearly ErrorResult-specific.
Attachment #8837263 - Attachment is obsolete: true
Attachment #8837263 - Flags: review?(bugs)
Attachment #8837261 - Flags: review?(bugs) → review+
Comment on attachment 8837262 [details] [diff] [review]
part 2.  Move the three ErrorResult-internal NS_ERROR_DOM_* values over to the ErrorResult error module

+  /* Represents an JS Value being thrown as an exception. */
Should it be 'a JS'?
Attachment #8837262 - Flags: review?(bugs) → review+
Comment on attachment 8837266 [details] [diff] [review]
part 3.  Use nsresult values in the ErrorResult error module in place of NS_ERROR_TYPE_ERR/NS_ERROR_RANGE_ERR in ErrorResult code

ok, so old NS_ERROR_TYPE_ERR and NS_ERROR_RANGE_ERR are still there.
I guess their usage should be replaced with ThrowTypeError and ThrowRangeError, but that is a separate bug or bugs?
Attachment #8837266 - Flags: review?(bugs) → review+
Blocks: 1338319
Keywords: sec-want
> Should it be 'a JS'?

Yes.  Fixed.

> ok, so old NS_ERROR_TYPE_ERR and NS_ERROR_RANGE_ERR are still there.

Yes.  They sort of predate ErrorResult using them, so...

> I guess their usage should be replaced with ThrowTypeError and ThrowRangeError

Probably, yes.  And yes, that's separate bug fodder.
Group: dom-core-security → core-security-release
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main54-]
Group: core-security-release
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.