1338319 - Add tests for the various codepaths added in bug 1141979

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 1141979 added various untested codepaths, some of which corrupt memory and crash if executed.  See bug 1328861 comment 12.

Please add tests for all the relevant codepaths.

Comment 1

[Boris Zbarsky [:bzbarsky]]

And note that I'm going to try to make this hard to mess up in bug 1328861, but we should still have tests for these codepaths.

Comment 2

[Tzuhao Kuo [:kaku]]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #0)
> Bug 1141979 added various untested codepaths, some of which corrupt memory
> and crash if executed.  See bug 1328861 comment 12.
> 
> Please add tests for all the relevant codepaths.

Sure.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Note that I'm about to change NS_ERROR_TYPE_ERR to not be special for ErrorResult.  If your intent is to throw a TypeError, you should do that....

Comment 4

[Tzuhao Kuo [:kaku]]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #3)
> Note that I'm about to change NS_ERROR_TYPE_ERR to not be special for
> ErrorResult.  If your intent is to throw a TypeError, you should do that....

Is it Bug 1339540? could you please cc me at Bug 1339540 because I'm not granted to access all security bugs...

Comment 5

[Andrew McCreight [:mccr8]]

(In reply to Tzuhao Kuo [:kaku] from comment #4)
> Is it Bug 1339540? could you please cc me at Bug 1339540 because I'm not
> granted to access all security bugs...

Done.

Comment 6

[Tzuhao Kuo [:kaku]]

(In reply to Andrew McCreight [:mccr8] from comment #5)
> (In reply to Tzuhao Kuo [:kaku] from comment #4)
> > Is it Bug 1339540? could you please cc me at Bug 1339540 because I'm not
> > granted to access all security bugs...
> 
> Done.

Thanks.

Comment 7

[Andrew Overholt [:overholt]]

Kaku, do you plan to work on this some time soon?

Comment 8

[Tzuhao Kuo [:kaku]]

(In reply to Andrew Overholt [:overholt] from comment #7)
> Kaku, do you plan to work on this some time soon?

I would like to remove all codes intruduced in bug 1141979 instead as the spec of ImageBitmap-extensions has been obsoleted, see https://w3c.github.io/mediacapture-worker/.

Also, bug 1348219 commnet 6 and bug 1348219 commnet 7 suggested that we remove them all.

Thoughts?

Comment 9

[Andrew Overholt [:overholt]]

WFM :)

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 11

[Andrew McCreight [:mccr8]]

Bug 1500733 removed this code.