1339641 - schedule l10n bumper on jamun

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Aki Sasaki (not active)]

Attachment: use curl instead of download_file, to get around old python ssl issues

We can point at mozilla-beta when we're ready for fx53b1.

Comment 1

[Aki Sasaki (not active)]

Attachment: schedule on bm77

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8837355 [details] [diff] [review]
schedule on bm77

Review of attachment 8837355 [details] [diff] [review]:
-----------------------------------------------------------------

In overall it looks straight forward. I have some questions below.

::: modules/l10n_bumper/manifests/init.pp
@@ +34,5 @@
> +    exec {
> +        # download mozharness
> +        "download_mozharness":
> +            require => File["${root}/download_mozharness.sh"],
> +            command => "${root}/download_mozharness.sh",

Hmm... How do we deal with deploying newer versions? Maybe we should explicitly pin the checkout to a particular revision instead of "tip"? At least it'll be reproducible if we decide to move the bumper to another machine.

::: modules/l10n_bumper/manifests/settings.pp
@@ +3,5 @@
> +
> +    $root = "/builds/l10n-bumper"
> +    $mailto = "[e-mail]"
> +    $share_base = "/builds/hg-shared"
> +    $mozharness_repo = "https://hg.mozilla.org/projects/jamun"

At some point we'll want to support more than one repos (beta+jamun). Maybe move this to moco-config.pp, something like https://hg.mozilla.org/build/puppet/file/tip/manifests/moco-config.pp#l181 and define the env name per master?

@@ +4,5 @@
> +    $root = "/builds/l10n-bumper"
> +    $mailto = "[e-mail]"
> +    $share_base = "/builds/hg-shared"
> +    $mozharness_repo = "https://hg.mozilla.org/projects/jamun"
> +    $mozharness_revision = "tip"

Shall we use "default" instead, because "tip" could be moved by Thunderbird release automation, for example.

Comment 3

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/jamun/rev/92041f45f73ab88d1517c215a1062f16ba0cbcf9
bug 1339641 - have l10n_bumper use curl to avoid old python ssl issues. r=rail

Comment 4

[Aki Sasaki (not active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90b255720b5c3531ec78e42260582cb395996841
bug 1339641 - update l10n_bumper. r=rail

Comment 5

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 90b255720b5c3531ec78e42260582cb395996841
> bug 1339641 - update l10n_bumper. r=rail

This one addresses the review comments in bug 
1337645 and brings the mozilla-inbound copy up to date with the jamun copy.  Still working on the puppet patch.

Comment 6

[Aki Sasaki (not active)]

Attachment: puppet-bumper2.diff

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90b255720b5c

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8837434 [details] [diff] [review]
puppet-bumper2.diff

Review of attachment 8837434 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/l10n_bumper/manifests/settings.pp
@@ +4,5 @@
> +    $root = "/builds/l10n-bumper"
> +    $mailto = "[e-mail]"
> +    $share_base = "/builds/hg-shared"
> +    $mozharness_repo = "https://hg.mozilla.org/projects/jamun"
> +    $mozharness_revision = "tip"

Can you remove $mozharness_repo and $mozharness_revision from this file when you land. They are not used from what I see.

:shipit:!

Comment 9

[Aki Sasaki (not active)]

https://hg.mozilla.org/build/puppet/rev/38b0dca747f4da5464c42cd03f334988baa3b38a
bug 1339641 - schedule l10n bumper for jamun on bm77. r=rail

Comment 10

[Aki Sasaki (not active)]

landed on puppet, rolled out to bm77, l10n bumper ran successfully.  Done!

Comment 11

[Rail Aliiev [:rail]]

woot! Thank you!