1339751 - Add gfxCriticalNote to dump error message when calling into ipc FatalError.

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Vincent Liu[:vliu]]

Some crash bugs like bug 1339080 were crash at ipc FatalError. We don't have a quickly view to see ipc message until decoding crash-stats to look into. Based on this, I think we can add gfxCriticalNote to dump Protocal name and its error message to see more information easier.

Comment 1

[Vincent Liu[:vliu]]

Attachment: 0001-Bug-1339751-Add-gfxCriticalNote-to-dump-error-messag.patch

Hi David,

Do you think if it helps for debugging crash issue from crash reporter?

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Bill, does bug 1338308 obsolete this by making IPC crash-metadata work again?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I don't understand. What is the problem this bug is trying to solve?

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Vincent Liu[:vliu] from comment #0)
> Some crash bugs like bug 1339080 were crash at ipc FatalError. We don't have
> a quickly view to see ipc message until decoding crash-stats to look into.
> Based on this, I think we can add gfxCriticalNote to dump Protocal name and
> its error message to see more information easier.

Isn't this already a crash annotation?

Comment 5

[Vincent Liu[:vliu]]

Sorry to late reply.

(In reply to Bill McCloskey (:billm) from comment #3)
> I don't understand. What is the problem this bug is trying to solve?

The bug doesn't intend to fix any bug, adding more information to help ipc crash issue happens.

(In reply to David Anderson [:dvander] from comment #4)
> (In reply to Vincent Liu[:vliu] from comment #0)
> > Some crash bugs like bug 1339080 were crash at ipc FatalError. We don't have
> > a quickly view to see ipc message until decoding crash-stats to look into.
> > Based on this, I think we can add gfxCriticalNote to dump Protocal name and
> > its error message to see more information easier.
> 
> Isn't this already a crash annotation?

When I looked into bug 1339080, I tried to find any possible clue to figure it out. From crash reporter, I didn't any information in crash-metadata. Please see in [1]. Based on this, I think if we have this ipc channel name and error message, it would be helpful for crash issue. How do you think? 

[1]: https://crash-stats.mozilla.com/report/index/b891dc40-775e-41d2-b624-ec0a92170213#tab-metadata

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Vincent Liu[:vliu] from comment #5)
> 
> [1]:
> https://crash-stats.mozilla.com/report/index/b891dc40-775e-41d2-b624-
> ec0a92170213#tab-metadata

That crash report is before bug 1338308 landed. On newer bugs you should see IPCFatalErrorProtocol in the content process metadata.

Comment 7

[Vincent Liu[:vliu]]

I will set this bug to WONTFIX since Gecko has already relative info to track. 



[1]: http://searchfox.org/mozilla-central/source/ipc/glue/ProtocolUtils.cpp#297