1339790 - Upgrade Firefox 53 to NSS 3.29.1 to fix binary compatibility issues

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Kai Engert [:KaiE:]]

This is the Firefox 53 version of bug 1339789, please read the summary over there.

I suggest to upgrade Firefox 53 to NSS 3.29, which is a small patch on top of NSS 3.29, to restore binary compatibility.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: bump version check in configure script

Comment 2

[Kai Engert [:KaiE:]]

setting ff51, ff52 to unaffected, because those are handled in bug 1339789

ff54 will be fixed with the next nightly merge on m-c

Comment 3

[Kai Engert [:KaiE:]]

We found an additional issue with NSS 3.28, bug 1340103.
We're trying to get this resolved ASAP.

Comment 4

[Kai Engert [:KaiE:]]

NSS 3.29.1 has been released.

Aurora try build with NSS 3.29.1:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66cdbe4c5e3e8978a69ce98ac5558c368c323a36

Comment 5

[Kai Engert [:KaiE:]]

plain aurora branch build, for comparison purposes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77b47fbba8a46b446ce9d5e942f96997e99355e6

Comment 6

[Kai Engert [:KaiE:]]

Attachment: update-to-3.29.1.txt

The try builds look good to me.

I think it's safe to pick up these two correctness fixes, which have been released as 3.29.1

(Identical story as in bug 1339789 for beta ff 52.)

Comment 7

[Kai Engert [:KaiE:]]

Comment on attachment 8839164 [details]
update-to-3.29.1.txt

[Feature/Bug causing the regression]:
nss 3.28 release, bug 957105

[User impact if declined]:
shipping ABI incompatible NSS into enterprise deployments

[Is this code covered by automated tests?]:
yes

[Has the fix been verified in Nightly?]:
only in nightly NSS tests, not yet in nightly ff

[Needs manual test from QE? If yes, steps to reproduce]: 
no

[List of other uplifts needed for the feature/fix]:
nothing else

[Is the change risky?]:
no

[Why is the change risky/not risky?]:
Passes all tests of both NSS and Firefox.

[String changes made/needed]:
none

Comment 8

[Kai Engert [:KaiE:]]

This is functionally equivalent to the change we already made for the mozilla-beta branch in bug 1339789.

Could you please consider to approve?

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8839164 [details]
update-to-3.29.1.txt

fix ABI issue for nss in aurora53

Comment 10

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cdeac40dccad
https://hg.mozilla.org/releases/mozilla-aurora/rev/7cc1b32ac996