1339844 - Implement Client.type

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Implement the `Client.type` attribute:

https://w3c.github.io/ServiceWorker/#client-type

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Implement the Client.type attribute. r=asuth

This adds the Client.type attribute.  We pretty much only ever expose 'window' here now since we don't represent workers as Client objects yet.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Implement the Client.type attribute. r=asuth

That was the wrong patch.  This is the one that adds Client.type.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Add Client.type to WPT tests. r=asuth

Test for Client.type in WPT tests.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P3 Test for Client.type in mochitest. r=asuth

Test for Client.type in our mochitest as well.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6ce770ded3b241966699710fa35968624d59f0b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7430d14ff90f
P1 Implement the Client.type attribute. r=asuth
https://hg.mozilla.org/integration/mozilla-inbound/rev/b185531eed21
P2 Add Client.type to WPT tests. r=asuth
https://hg.mozilla.org/integration/mozilla-inbound/rev/f45e73d6c9ff
P3 Test for Client.type in mochitest. r=asuth

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7430d14ff90f
https://hg.mozilla.org/mozilla-central/rev/b185531eed21
https://hg.mozilla.org/mozilla-central/rev/f45e73d6c9ff

Comment 8

[Chris Mills [:cmills]]

I've documented this:

https://developer.mozilla.org/en-US/docs/Web/API/Client
https://developer.mozilla.org/en-US/docs/Web/API/Client/type

I've also added a note to the Fx54 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/54#Web_workers_and_Service_Workers

Let me know if this look OK. Thanks!