Closed
Bug 1339844
Opened 6 years ago
Closed 6 years ago
Implement Client.type
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files, 1 obsolete file)
|
4.58 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
|
6.23 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
|
1.83 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
Implement the `Client.type` attribute: https://w3c.github.io/ServiceWorker/#client-type
|
Assignee | |
Comment 1•6 years ago
|
||
This adds the Client.type attribute. We pretty much only ever expose 'window' here now since we don't represent workers as Client objects yet.
Attachment #8837712 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 2•6 years ago
|
||
That was the wrong patch. This is the one that adds Client.type.
Attachment #8837712 -
Attachment is obsolete: true
Attachment #8837712 -
Flags: review?(bugmail)
Attachment #8837713 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Test for Client.type in WPT tests.
Attachment #8837714 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Test for Client.type in our mochitest as well.
Attachment #8837715 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6ce770ded3b241966699710fa35968624d59f0b
|
||
Updated•6 years ago
|
Attachment #8837713 -
Flags: review?(bugmail) → review+
|
|
||
Updated•6 years ago
|
Attachment #8837714 -
Flags: review?(bugmail) → review+
|
|
||
Updated•6 years ago
|
Attachment #8837715 -
Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7430d14ff90f P1 Implement the Client.type attribute. r=asuth https://hg.mozilla.org/integration/mozilla-inbound/rev/b185531eed21 P2 Add Client.type to WPT tests. r=asuth https://hg.mozilla.org/integration/mozilla-inbound/rev/f45e73d6c9ff P3 Test for Client.type in mochitest. r=asuth
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7430d14ff90f https://hg.mozilla.org/mozilla-central/rev/b185531eed21 https://hg.mozilla.org/mozilla-central/rev/f45e73d6c9ff
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
|
Assignee | |
Updated•6 years ago
|
Keywords: dev-doc-needed
|
||
Comment 8•6 years ago
|
||
I've documented this: https://developer.mozilla.org/en-US/docs/Web/API/Client https://developer.mozilla.org/en-US/docs/Web/API/Client/type I've also added a note to the Fx54 release notes: https://developer.mozilla.org/en-US/Firefox/Releases/54#Web_workers_and_Service_Workers Let me know if this look OK. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•