Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Implement the `Client.type` attribute:

https://w3c.github.io/ServiceWorker/#client-type
This adds the Client.type attribute.  We pretty much only ever expose 'window' here now since we don't represent workers as Client objects yet.
Attachment #8837712 - Flags: review?(bugmail)
That was the wrong patch.  This is the one that adds Client.type.
Attachment #8837712 - Attachment is obsolete: true
Attachment #8837712 - Flags: review?(bugmail)
Attachment #8837713 - Flags: review?(bugmail)
Test for Client.type in WPT tests.
Attachment #8837714 - Flags: review?(bugmail)
Test for Client.type in our mochitest as well.
Attachment #8837715 - Flags: review?(bugmail)
Blocks: 1339885
Attachment #8837713 - Flags: review?(bugmail) → review+
Attachment #8837714 - Flags: review?(bugmail) → review+
Attachment #8837715 - Flags: review?(bugmail) → review+

Comment 6

2 years ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7430d14ff90f
P1 Implement the Client.type attribute. r=asuth
https://hg.mozilla.org/integration/mozilla-inbound/rev/b185531eed21
P2 Add Client.type to WPT tests. r=asuth
https://hg.mozilla.org/integration/mozilla-inbound/rev/f45e73d6c9ff
P3 Test for Client.type in mochitest. r=asuth

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7430d14ff90f
https://hg.mozilla.org/mozilla-central/rev/b185531eed21
https://hg.mozilla.org/mozilla-central/rev/f45e73d6c9ff
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.