1339885 - clients-matchall-client-types.https.html has commented out test cases

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

It looks like we accidentally left some commented out test cases in clients-matchall-client-types.https.html when we imported it from blink.  We won't pass these, but they shouldn't be commented out since other browsers might pass them.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Commented out block is here:

https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/service-workers/service-worker/clients-matchall-client-types.https.html#65

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Basing this on my changes in bug 1339844.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

This patch:

1) Makes clients.matchAll() rejections fail the test instead of timing out.
2) Separates window-only tests (which we pass) from other tests (which we fail) into different test cases.
3) Marks the second test case as expected fail.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8837741 [details] [diff] [review]
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

r=me.

It's too bad we can't postMessage exception values, and hence lose things like stacks.  :(

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6296e675694a
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6296e675694a