clients-matchall-client-types.https.html has commented out test cases

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM: Service Workers
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
It looks like we accidentally left some commented out test cases in clients-matchall-client-types.https.html when we imported it from blink.  We won't pass these, but they shouldn't be commented out since other browsers might pass them.
(Assignee)

Comment 1

10 months ago
Commented out block is here:

https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/service-workers/service-worker/clients-matchall-client-types.https.html#65
(Assignee)

Updated

10 months ago
Blocks: 1189686
(Assignee)

Comment 2

10 months ago
Basing this on my changes in bug 1339844.
Depends on: 1339844
(Assignee)

Comment 3

10 months ago
Created attachment 8837741 [details] [diff] [review]
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

This patch:

1) Makes clients.matchAll() rejections fail the test instead of timing out.
2) Separates window-only tests (which we pass) from other tests (which we fail) into different test cases.
3) Marks the second test case as expected fail.
Attachment #8837741 - Flags: review?(bzbarsky)
Comment on attachment 8837741 [details] [diff] [review]
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

r=me.

It's too bad we can't postMessage exception values, and hence lose things like stacks.  :(
Attachment #8837741 - Flags: review?(bzbarsky) → review+

Comment 5

10 months ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6296e675694a
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6296e675694a
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.