Closed Bug 1339885 Opened 5 years ago Closed 5 years ago

clients-matchall-client-types.https.html has commented out test cases

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It looks like we accidentally left some commented out test cases in clients-matchall-client-types.https.html when we imported it from blink.  We won't pass these, but they shouldn't be commented out since other browsers might pass them.
Blocks: 1189686
Basing this on my changes in bug 1339844.
Depends on: 1339844
This patch:

1) Makes clients.matchAll() rejections fail the test instead of timing out.
2) Separates window-only tests (which we pass) from other tests (which we fail) into different test cases.
3) Marks the second test case as expected fail.
Attachment #8837741 - Flags: review?(bzbarsky)
Comment on attachment 8837741 [details] [diff] [review]
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz

r=me.

It's too bad we can't postMessage exception values, and hence lose things like stacks.  :(
Attachment #8837741 - Flags: review?(bzbarsky) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6296e675694a
Uncomment test cases from WPT test and move to separate case that can be marked expected fail. r=bz
https://hg.mozilla.org/mozilla-central/rev/6296e675694a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.