Closed Bug 1339848 Opened 4 years ago Closed 4 years ago

Wrong message is displayed when trying to allow permanent access to your screen or window

Categories

(Firefox :: Site Identity, defect, P2)

Product:
Firefox
Component:
Site Identity
Version:
54 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- verified

People

(Reporter: hani.yacoub, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(2 files)

Screen_permanent_access.png
58.53 KB, image/png
Details
Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted.
59 bytes, text/x-review-board-request
florian
: review+
Details 
[Affected versions]: 
Nightly 54.0a1

[Affected platforms]:
All platforms: Ubuntu 16.04 x64, Windows 10 x 64, Mac OS X 10.11

[Steps to reproduce]:
1. Go to https://people-mozilla.org/~fqueze2/webrtc/
2. Click on "Screen".
3. Check "Remember this decision".

[Expected result]:
"%S can not allow permanent access to your screen." message is displayed.

[Actual result]:
"Nightly can not allow permanent access to your screen without asking which one to share." message is displayed.
Blocks: 1188147
Whiteboard: [fxprivacy] [triage]
Florian do you have any thoughts here?
Flags: needinfo?(florian)
Priority: -- → P2
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
I don't remember the outcome of the discussion we had with Michelle about this string. Either of the strings mentioned in comment 0 seem technically accurate, but I guess the shorter "can not allow permanent access to your screen." may be less confusing to users.
Flags: needinfo?(florian)
This bug was logged based on comment https://bugzilla.mozilla.org/show_bug.cgi?id=1319112#c22.
Assignee: nobody → nhnt11
Comment on attachment 8846636 [details]
Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted.

https://reviewboard.mozilla.org/r/119656/#review121516
Attachment #8846636 - Flags: review?(florian) → review+
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a77ebcd6f910
Simplify the string used to indicate that permanent access to the screen cannot be granted. r=florian
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/a77ebcd6f910
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Build ID: 20170317030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Shouldn't this be uplifted to Aurora?
Flags: needinfo?(jhofmann)
Flags: needinfo?(bmo)
String change :/
status-firefox54: affected → wontfix
Flags: needinfo?(jhofmann)
Flags: needinfo?(bmo)
status-firefox53: --- → affected
You need to log in before you can comment on or make changes to this bug.