1339848 - Wrong message is displayed when trying to allow permanent access to your screen or window

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[Hani Yacoub, Desktop QA]

Attachment: Screen_permanent_access.png

[Affected versions]: 
Nightly 54.0a1

[Affected platforms]:
All platforms: Ubuntu 16.04 x64, Windows 10 x 64, Mac OS X 10.11

[Steps to reproduce]:
1. Go to https://people-mozilla.org/~fqueze2/webrtc/
2. Click on "Screen".
3. Check "Remember this decision".

[Expected result]:
"%S can not allow permanent access to your screen." message is displayed.

[Actual result]:
"Nightly can not allow permanent access to your screen without asking which one to share." message is displayed.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Florian do you have any thoughts here?

Comment 2

[Florian Quèze [:florian]]

I don't remember the outcome of the discussion we had with Michelle about this string. Either of the strings mentioned in comment 0 seem technically accurate, but I guess the shorter "can not allow permanent access to your screen." may be less confusing to users.

Comment 3

[Hani Yacoub, Desktop QA]

This bug was logged based on comment https://bugzilla.mozilla.org/show_bug.cgi?id=1319112#c22.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted.

Review commit: https://reviewboard.mozilla.org/r/119656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119656/

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8846636 [details]
Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted.

https://reviewboard.mozilla.org/r/119656/#review121516

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a77ebcd6f910
Simplify the string used to indicate that permanent access to the screen cannot be granted. r=florian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a77ebcd6f910

Comment 8

[Hani Yacoub, Desktop QA]

Build ID: 20170317030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 9

[Hani Yacoub, Desktop QA]

Shouldn't this be uplifted to Aurora?

Comment 10

[Johann Hofmann [:johannh]]

String change :/