Closed Bug 1339908 Opened 7 years ago Closed 7 years ago

Blocklist malware dlls smci32.dll and smci64.dll

Categories

(Toolkit :: Blocklist Policy Requests, defect)

Product:
Toolkit
Component:
Blocklist Policy Requests
Version:
47 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox53 + wontfix
firefox54 + fixed
firefox55 + fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
1.05 KB, patch
jimm
: review+
gchang
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
These dlls are associated with known malware, and may cause big spikes in startup crashes. (See bug 1323498).

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Aipc%3A%3AMessageChannel%3A%3AOnChannelErrorFromLink#correlations
Flags: needinfo?(jmathies)
Jim - What needs to happen to get these blocked?
someone needs to write a patch. I was planning on trying to get to that, hence the ni here.
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → jmathies
Flags: needinfo?(jmathies)

    
  

        Attachment #8842413 -
        Flags: review?(benjamin)

    
    

    
  
Comment on attachment 8842413 [details] [diff] [review]
patch

nit please use brace spacing the same as the rest of this file. Also mention this bug number.

        Attachment #8842413 -
        Flags: review?(benjamin) → review+

    
    

    
  
Jimm - can we land and uplift this?
Flags: needinfo?(jmathies)

    
    

    
  
[Tracking Requested - why for this release]: Tracking to make sure this one doesn't get lost for a crash in the blocked bug.

          status-firefox53:
          --- → affected

          status-firefox54:
          --- → affected

          status-firefox55:
          --- → affected

          tracking-firefox53:
          --- → ?

          tracking-firefox54:
          --- → ?

    
    

    
  
Tracking for 53 onwards. I'll email jimm

          tracking-firefox53:
          ? → +

          tracking-firefox54:
          ? → +

          tracking-firefox55:
          --- → +

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
updated per review comments.

        Attachment #8842413 -
        Attachment is obsolete: true
Flags: needinfo?(jmathies)

        Attachment #8852008 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 8852008 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]:
crashing dll injection issue
[User impact if declined]:
crashy browser
[Is this code covered by automated tests?]:
yes
[Has the fix been verified in Nightly?]:
no
[Needs manual test from QE? If yes, steps to reproduce]: 
no
[List of other uplifts needed for the feature/fix]:
none
[Is the change risky?]:
meh, blocking dlls is always a bit risky. hence why I'm not flagging for beta uplift.
[Why is the change risky/not risky?]:
[String changes made/needed]:
none

        Attachment #8852008 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b21231a525e9
Blocklist goobzo associated dlls. r=bsmedberg
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b21231a525e9
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox55:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

    
    

    
  
Comment on attachment 8852008 [details] [diff] [review]
patch

Block malware dlls. Aurora54+.

        Attachment #8852008 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
jimm: can we have an uplift for beta?
Flags: needinfo?(jmathies)

    
    

    
  
Two weeks before release seems a bit risky for a change like this.
Flags: needinfo?(jmathies)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: