134001 - Composer uploads images when "include images and other file" is unchecked.

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.9+)
Gecko/20020327 Netscape6/6.2.1+
BuildID:    2002032708

Composer will publish images via ftp regardless of whether "include images and
other files" on publish page dialog is checked or unchecked.

Reproducible: Always
Steps to Reproduce:
1.Launch NS build 2002032708
2.Launch new Composer window.
3.Enter some text and at least one image.
4.Click file|publish as...
5.Fill-in appropriate info to publish to ftp site(site name, username, password,
etc.)
6.Uncheck "include images and other files".
7.Click publish.
8.Navigate to URL of published page.

Actual Results:  Publishing dialog shows both the page as well as the image
being uploaded.  The image is displayed on the published page.

Expected Results:  If the "include images and other files" selection is
unchecked, images should not be uploaded.

Comment 1

[michael wendell]

I am also seeing this problem on Win 98 using the 03-28 trunk.

Marking NEW.

Comment 2

[michael wendell]

Reassigning to cmanske and adding a couple CC's

Comment 3

[Charles Manske]

Damn. Changing the subdirectory format from always being at least "/" to using
"" for root directory has competely messed this up. I'll have to add another
boolean to publishing prefs data to store this :(

Comment 4

[Syd Logan]

Sounds like a potential privacy, perhaps even security issue in that unwanted
content may be published to a public location. Plussing.

Comment 5

[Charles Manske]

Attachment: Patch v1

Add another bool to site data object to remember if user wants to also publish
images and other associated files for each site.
In publishprefs.js, these are in the core GetPublishData and SetPublishData
methods.

Comment 6

[Charles Manske]

Attachment: Patch v2

Tweaked publishprefs: only save "otherDir" if publishOtherFiles is true.

Comment 7

[Akkana Peck]

Comment on attachment 76804 [details] [diff] [review]
Patch v2

r=akkana

Comment 8

[kinmoz]

Comment on attachment 76804 [details] [diff] [review]
Patch v2

sr=[e-mail]

Comment 9

[Charles Manske]

This bug is critical to Publishing feature

Comment 10

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on behalf of ADT) for checkin to the 1.0 trunk.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 76804 [details] [diff] [review]
Patch v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[Charles Manske]

checked in

Comment 13

[michael wendell]

Verified on 04-05 trunk.