RID extmap checks in sdputils.js assume RID is the only extension in use

RESOLVED FIXED in Firefox 54

Status

()

Core
WebRTC
P1
normal
Rank:
15
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 1 bug)

45 Branch
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
sdputils.js hardcodes "extmap:1" for RID

This breaks if another extension is enabled....
(Assignee)

Comment 1

10 months ago
Created attachment 8837942 [details] [diff] [review]
don't hardcode extmap ids for simulcast RID extension

jib -- drno and bwc are on PTO for the rest of the week, please review (simple fix)
Attachment #8837942 - Flags: review?(jib)
(Assignee)

Updated

10 months ago
Rank: 15
Priority: -- → P1

Comment 2

10 months ago
Comment on attachment 8837942 [details] [diff] [review]
don't hardcode extmap ids for simulcast RID extension

Review of attachment 8837942 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8837942 - Flags: review?(jib) → review+

Comment 3

10 months ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84ea325bf183
don't hardcode extmap ids for simulcast RID extension r=jib
(Assignee)

Updated

10 months ago
Blocks: 1340372

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/84ea325bf183
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.