Closed
Bug 1340054
Opened 8 years ago
Closed 8 years ago
RID extmap checks in sdputils.js assume RID is the only extension in use
Categories
(Core :: WebRTC, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.92 KB,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
sdputils.js hardcodes "extmap:1" for RID
This breaks if another extension is enabled....
|
Assignee | |
Comment 1•8 years ago
|
||
jib -- drno and bwc are on PTO for the rest of the week, please review (simple fix)
Attachment #8837942 -
Flags: review?(jib)
|
|
Assignee | |
Updated•8 years ago
|
Rank: 15
Priority: -- → P1
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8837942 [details] [diff] [review]
don't hardcode extmap ids for simulcast RID extension
Review of attachment 8837942 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8837942 -
Flags: review?(jib) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84ea325bf183
don't hardcode extmap ids for simulcast RID extension r=jib
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•