Closed Bug 1300665 Opened 8 years ago Closed 7 years ago

Missing support for RTP toffset, abs-time and 3gpp:video-orientation

Categories

(Core :: WebRTC: Networking, defect, P2)

Product:
Core
Component:
WebRTC: Networking
Version:
48 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: wanghb89, Assigned: jesup)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Add abs-send-time and toffset header extension usage and negotiation
9.49 KB, patch
bwc
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160823121617

Steps to reproduce:

create webrtc offer use js.createOffer without sdpConstraints




Actual results:

v=0

o=mozilla...THIS_IS_SDPARTA-48.0.2 1031616216810396843 0 IN IP4 0.0.0.0

s=-

t=0 0

a=sendrecv

a=fingerprint:sha-256 A4:DC:75:4F:80:CA:49:07:7E:D9:33:EC:36:F8:B0:F0:9B:DB:BB:5E:7C:49:AC:28:F1:D1:A4:EA:C3:5C:32:F6

a=group:BUNDLE sdparta_0 sdparta_1

a=ice-options:trickle

a=msid-semantic:WMS *

m=audio 54685 UDP/TLS/RTP/SAVPF 109 9 0 8

c=IN IP4 10.10.10.1

a=candidate:0 1 UDP 2122121471 192.167.1.2 54683 typ host

a=candidate:2 1 UDP 2122187007 169.254.168.185 54684 typ host

a=candidate:4 1 UDP 2122252543 10.10.10.1 54685 typ host

a=candidate:6 1 UDP 2122055935 192.168.128.1 54686 typ host

a=candidate:8 1 UDP 2121990399 192.168.1.105 54687 typ host

a=candidate:0 2 UDP 2122121470 192.167.1.2 54688 typ host

a=candidate:2 2 UDP 2122187006 169.254.168.185 54689 typ host

a=candidate:4 2 UDP 2122252542 10.10.10.1 54690 typ host

a=candidate:6 2 UDP 2122055934 192.168.128.1 54691 typ host

a=candidate:8 2 UDP 2121990398 192.168.1.105 54692 typ host

a=sendrecv

a=end-of-candidates

a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level

a=fmtp:109 maxplaybackrate=48000;stereo=1

a=ice-pwd:5fac0b9cee60ca17ce8e99ffcd9dbdcc

a=ice-ufrag:efae95ee

a=mid:sdparta_0

a=msid:{f65d2d0a-3b04-42ea-b00d-ecc425ad5cc6} {2a248154-82c4-4c7a-b728-f85ed2dab8e8}

a=rtcp:54690 IN IP4 10.10.10.1

a=rtcp-mux

a=rtpmap:109 opus/48000/2

a=rtpmap:9 G722/8000/1

a=rtpmap:0 PCMU/8000

a=rtpmap:8 PCMA/8000

a=setup:actpass

a=ssrc:3742940267 cname:{2ab894c2-6297-4c88-9f64-a6d41fcebe06}

m=video 54695 UDP/TLS/RTP/SAVPF 120 126 97

c=IN IP4 10.10.10.1

a=candidate:0 1 UDP 2122121471 192.167.1.2 54693 typ host

a=candidate:2 1 UDP 2122187007 169.254.168.185 54694 typ host

a=candidate:4 1 UDP 2122252543 10.10.10.1 54695 typ host

a=candidate:6 1 UDP 2122055935 192.168.128.1 54696 typ host

a=candidate:8 1 UDP 2121990399 192.168.1.105 54697 typ host

a=candidate:0 2 UDP 2122121470 192.167.1.2 54698 typ host

a=candidate:2 2 UDP 2122187006 169.254.168.185 54699 typ host

a=candidate:4 2 UDP 2122252542 10.10.10.1 54700 typ host

a=candidate:6 2 UDP 2122055934 192.168.128.1 54701 typ host

a=candidate:8 2 UDP 2121990398 192.168.1.105 54702 typ host

a=sendrecv

a=end-of-candidates

a=fmtp:126 profile-level-id=42e01f;level-asymmetry-allowed=1;packetization-mode=1

a=fmtp:97 profile-level-id=42e01f;level-asymmetry-allowed=1

a=fmtp:120 max-fs=12288;max-fr=60

a=ice-pwd:5fac0b9cee60ca17ce8e99ffcd9dbdcc

a=ice-ufrag:efae95ee

a=mid:sdparta_1

a=msid:{f65d2d0a-3b04-42ea-b00d-ecc425ad5cc6} {099261fe-6ab7-47f1-88e2-4e0bd2c23a28}

a=rtcp:54700 IN IP4 10.10.10.1

a=rtcp-fb:120 nack

a=rtcp-fb:120 nack pli

a=rtcp-fb:120 ccm fir

a=rtcp-fb:126 nack

a=rtcp-fb:126 nack pli

a=rtcp-fb:126 ccm fir

a=rtcp-fb:97 nack

a=rtcp-fb:97 nack pli

a=rtcp-fb:97 ccm fir

a=rtcp-mux

a=rtpmap:120 VP8/90000

a=rtpmap:126 H264/90000

a=rtpmap:97 H264/90000

a=setup:actpass

a=ssrc:3709476863 cname:{2ab894c2-6297-4c88-9f64-a6d41fcebe06}



Expected results:

I want the offer sdp with
 ↵a=extmap:2 urn:ietf:params:rtp-hdrext:toffset
↵a=extmap:3 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
↵a=extmap:4 urn:3gpp:video-orientation
Anyone help?
Component: Untriaged → WebRTC: Networking
Product: Firefox → Core
Firefox does not support any of these three extensions yet.
We can probably look into adding support for these once the webrtc.org 49 code base has merged.
Status: UNCONFIRMED → NEW
Depends on: 1250356
Ever confirmed: true
Summary: create webrtc offer without extmap field → Missing support for RTP toffset, abs-time and 3gpp:video-orientation
backlog: --- → webrtc/webaudio+
Rank: 29
Priority: -- → P2
Any updates on when this is planned?
See Also: → 1335226
MozReview-Commit-ID: 3h9C8XziNky
Attachment #8832498 - Flags: review?(docfaraday)
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Comment on attachment 8832498 [details] [diff] [review]
Add abs-send-time and toffset header extension usage and negotiation

Review of attachment 8832498 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits.

::: media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ +2293,5 @@
>  JsepSessionImpl::SetupDefaultRtpExtensions()
>  {
>    AddAudioRtpExtension("urn:ietf:params:rtp-hdrext:ssrc-audio-level",
>                         SdpDirectionAttribute::Direction::kSendonly);
> +  AddVideoRtpExtension("http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time",

Fold to 80

::: media/webrtc/signaling/src/peerconnection/MediaPipelineFactory.cpp
@@ +821,5 @@
> +  std::vector<webrtc::RtpExtension> extmaps;
> +  if (details) {
> +    // @@NG read extmap from track
> +    details->ForEachRTPHeaderExtension(
> +      [&conduit,&extmaps](const SdpExtmapAttributeList::Extmap& extmap)

|conduit| doesn't need to be in the capture list anymore, right?
Attachment #8832498 - Flags: review?(docfaraday) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34d05a052148
Add abs-send-time and toffset header extension usage and negotiation r=bwc
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a2ffd6f443c
Add abs-send-time and toffset header extension usage and negotiation r=bwc
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b4273424e32d for the same old "test_peerConnection_simulcastOffer.html | Error in test execution: Error: Timed out waiting for frames timeout", this time varying between one and eight failures per push, until this patch met up with the https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=5a7f8a39068aa5913543b61c0220146cdb1cfc5f merge, at which point the failure switched to https://treeherder.mozilla.org/logviewer.html#?job_id=77024155&repo=mozilla-inbound and so far, at least on Linux, is looking like permaorange.
Depends on: 1340054
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a969e9d153
Add abs-send-time and toffset header extension usage and negotiation r=bwc
Blocks: 1340372
https://hg.mozilla.org/mozilla-central/rev/40a969e9d153
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: