1340129 - .ogv videos only working after skipping forward/backwards on the progress bar

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Note]:
- 

[Affected versions]:
- Latest Nightly 54.0a1 (2017-02-15) 
- Latest Aurora 53.0a2 (2017-02-15) 

[Affected platforms]:
- Windows 10 x64
- Mac OS X 10.12
- Ubuntu 14.04 x64

[Steps to reproduce]:
1. Launch Firefox
2. Open https://www.s-config.com/core/wp-content/uploads/2015/09/Ukidig.ogv

[Expected result]:
- The video is successfully started
- There are no video/audio playback issues

[Actual result]:
- Only audio is played back until skipping forward/backwards on the progress bar

[Regression range]:
- This issue is a regression
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2edf2a4c017aa348db91dcc979d0634f9359ad72&tochange=1a0f8ac320e15a91a047fada7fa32e8d947a3db9


[Additional notes]:
- This issue isn't e10s related
- Beta and Release builds are not affected

Comment 1

[Jean-Yves Avenard [:jya]]

likely bug 1325707, I have ideas about that one

Comment 2

[Jean-Yves Avenard [:jya]]

[Tracking Requested - why for this release]: playback regression. It appears that empty content can be found in ogg file

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1340129: P1. Allow empty raw frames.

Review commit: https://reviewboard.mozilla.org/r/113252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113252/

Comment 4

[Gerald Squelart [:gerald] (he/him)]

Comment on attachment 8838293 [details]
Bug 1340129: P1. Allow empty raw frames.

https://reviewboard.mozilla.org/r/113252/#review114692

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3cbccb9cba
P1. Allow empty raw frames. r=gerald

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ed3cbccb9cba

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8838293 [details]
Bug 1340129: P1. Allow empty raw frames.

Approval Request Comment
[Feature/Bug causing the regression]: 1325707
[User impact if declined]: Some videos will no longer play
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: manually verified.
[Needs manual test from QE? If yes, steps to reproduce]: yes
[List of other uplifts needed for the feature/fix]: just this patch.
[Is the change risky?]: no
[Why is the change risky/not risky?]: we incorrectly blocked all empty allocations, but turned out they can happen.
[String changes made/needed]: no

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8838293 [details]
Bug 1340129: P1. Allow empty raw frames.

fix recent regression in aurora and beta.

Thanks for the quick fix.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2af97db52557

Comment 10

[[Back July 11] Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/42db8a0b3673

Comment 11

[[Back July 11] Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-esr52/rev/42db8a0b3673

Comment 12

[Sajedul Islam]

I have reproduced this bug with Nightly 54.0a1 (2017-02-16) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Beta, Aurora and Nightly !

Build   ID    20170220070057
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

Build   ID    20170222004022
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

Build   ID    20170223030204
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170222]

Comment 13

[Cornel Ionce [:cornel_ionce]]

Also confirming the fix on Mac OS X 10.11.6 and Ubuntu 14.04 x64 using Firefox 52.0b9 (20170223185858).

Comment 14

[Abe - QA (:Abe_LV)]

Reopening this bug as it is reproducible with the latest nightly on Windows-10 x64.
It plays only the audio, not the video unless the user seeks forward or backward.

Screen capture- https://testing-1.tinytake.com/sf/MjU5NzE5MF83ODE1OTQz
In this screen capture, a blurred background image is visible, but in actuall view it is just a blank player window

Test Environment:
Version 	62.0a1
Build ID 	20180515100038
Update Channel 	nightly
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Comment 15

[[Back July 11] Ryan VanderMeulen]

This bug was fixed and verified over a year ago. Please file a new bug for what you're seeing (preferably with a regression range).

Comment 16

[Abe - QA (:Abe_LV)]

A new bug (bug 1462728) is filed with a new regression range.