1340160 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.media.CodecProxy.processInput(CodecProxy.java)

Status: RESOLVED DUPLICATE of bug 1345599

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-f51cc1bf-ee28-44ea-b748-6b0962170215.
=============================================================

New crash which started with Build 20170215110205: http://bit.ly/2lSy3KA. Need help bucketing this in the right place so this the ni on snorp.

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=195049fabb7ac5709e5f75614ba630ba3d1b5a9b&tochange=0a7831d838f793a263456df62f95a615472a7f95

Two Huawei devices seem to be more affected - the Honor 8 and the Nexus 6P.

Comment 1

[Nicholas Nethercote [inactive]]

#1 topcrash in Nightly 20170217110224, with 26 occurrences it's far ahead of #2, which has 6.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

John, looks like a problem with OOP decoding.

Comment 3

[John Lin [:jhlin][:jolin]]

Similar to bug 1340582, though different exceptions not caught by the fix there were thrown. Will add more handling code to address this.

Comment 4

[Julian Seward [:jseward]]

Still #1 topcrash in Android Nightly 20170223110225.

Comment 5

[Nicholas Nethercote [inactive]]

Still #1 topcrash by a long way in Nightly 20170303110215.

John, do you have an ETA on this? Thank you.

Comment 6

[John Lin [:jhlin][:jolin]]

Sorry for the late reply. Will send a patch for review before end of the day.

Comment 7

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1340160 - catch more local and remote Java exceptions.

Review commit: https://reviewboard.mozilla.org/r/117448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117448/

Comment 8

[John Lin [:jhlin][:jolin]]

Attachment 8843843 [details] will need rebasing if bug 1344347 lands first.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8843843 [details]
Bug 1340160 - catch more local and remote Java exceptions.

https://reviewboard.mozilla.org/r/117448/#review119228

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d97a9fd45201
catch more local and remote Java exceptions. r=snorp

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d97a9fd45201

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 13

[Jan Henning [:JanH]]

No longer crashes (thanks for fixing this), but still not entirely satisfactory - filed bug 1345599 for this.

Comment 14

[John Lin [:jhlin][:jolin]]

Comment on attachment 8843843 [details]
Bug 1340160 - catch more local and remote Java exceptions.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1326026
[User impact if declined]: browser crash
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: it catches more exceptions
[String changes made/needed]: none

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8843843 [details]
Bug 1340160 - catch more local and remote Java exceptions.

Fix a crash. Aurora54+.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10056139635b

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8843843 [details]
Bug 1340160 - catch more local and remote Java exceptions.

Browser crash fix, Beta53+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f08d4487101

Comment 19

[Oana Horvath [:ohorvath]]

Saw this crash again on Aurora 54.0a2 (2017-03-09), while waiting for this page to load: https://direlogomachist.itch.io/ember-interlude. Occurred 4/4 times.
Crash report: https://crash-stats.mozilla.com/report/index/45a9d016-0ae2-4aad-85b9-8cc812170310

Devices:
Nexus 6 (Android 7.0)
Asus ZenPad 8.0 Z380KL (Android 6.0.1)

note: Also crashed on Nightly 55, but could only reproduce it once.
On Beta 53, it did not reproduce.

Comment 20

[Sorina Florean [:sflorean]]

Tested with Nexus 6 (Android 7.0) and Huawei MediaPad M2 (Android 5.1.1) on Firefox 53 Beta 2 and didn't saw this crash. Mark the flag verified.

Comment 21

[John Lin [:jhlin][:jolin]]

Some log shows shared memory error and looks like what bug 1345599 tries to fix. Set it as a dup.