Closed Bug 1340195 Opened 3 years ago Closed 3 years ago

Remove e10s block for LastPass

Categories

(Firefox :: Extension Compatibility, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox52 + wontfix
firefox53 + fixed
firefox54 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1332692 +++

The e10s block for LastPass added in bug 1332692 can be removed.

We can't just back out 1332692 because we need to increase the add-on version instead of rolling it back.
[Tracking Requested - why for this release]:

Revert e10s LastPass block landed for 52/esr
I'll wait until the e10s meeting tomorrow to double check on this before going forward
Comment on attachment 8838113 [details]
Bug 1340195 - Remove e10s block for LastPass.

https://reviewboard.mozilla.org/r/113102/#review114958

Per meeting today - I think we only want to do this for Beta.
Attachment #8838113 - Flags: review?(mconley) → review-
Is there any more action needed for 52 here, or are we keeping the lastpass block after all?
Flags: needinfo?(felipc)
Ok, so the plan from the last e10s meeting was: unblock in beta, keep blocked in release.  Instead of writing yet another patch to do this conditionally on the update channel (and dealing with approvals and late uplifts), I plan to just let the block ride to release and then remove it only from beta after the merge (or right now in aurora)
Flags: needinfo?(felipc)
Comment on attachment 8838113 [details]
Bug 1340195 - Remove e10s block for LastPass.

Hey Mike, re-requesting review here. Instead of modifying this patch to only apply to beta and not release, I let the previous block ride to release, and then I plan to only land this on central and aurora this week so that the block is removed for the next beta.
Attachment #8838113 - Flags: review- → review?(mconley)
Comment on attachment 8838113 [details]
Bug 1340195 - Remove e10s block for LastPass.

https://reviewboard.mozilla.org/r/113102/#review118338

felipe says that the plan of record is to only have the block exist on the Release channel for a single release (52). This block-removal will land on central and aurora, and will merge in the next uplift to beta (so it should be in beta 53).

The hope is that their issues will be sorted by the time 53 goes out the door. If not, we'll put the block back in 53.
Attachment #8838113 - Flags: review?(mconley) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4ff72c2c865f
Remove e10s block for LastPass. r=mconley
Comment on attachment 8838113 [details]
Bug 1340195 - Remove e10s block for LastPass.

Approval Request Comment
[Feature/Bug causing the regression]: remove the block of e10s for LastPass v4 users for the next beta
[User impact if declined]: people using the beta versions of LastPass (v4) will continue to be blocked from e10s
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: addons blocking only applies to beta/release
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: LastPass v4 is only on beta stage and is not the direct download found on AMO (you need to navigate to "Other versions" to find it). The currently published v3 is blocked unconditionally by being mpc=false
[String changes made/needed]: none
Attachment #8838113 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4ff72c2c865f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8838113 [details]
Bug 1340195 - Remove e10s block for LastPass.

Taking off the block for 53 here. We need this to land before the patches from bug 1342490
Attachment #8838113 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.