Closed Bug 1332692 Opened 3 years ago Closed 3 years ago

Use system add-on to block e10s activation for LastPass users

Categories

(Firefox :: Extension Compatibility, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 54
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: shell, Assigned: Felipe)

References

Details

Attachments

(3 files, 1 obsolete file)

Can these be added to the system add-on block list so they don't receive e10s based on currently reported issues?

LastPass    support@lastpass.com  all 4.x is ideal
4.1.32a is current bug 1305831

Amazon Assistant for Firefox	abb-acer@amazon.com	all 10.x is ideal.  
two version showed up in specific 10.161.13.1002 and 10.1612.1.304) bug 1332643
Blocks: 1331003
Blocks: 1332643
Priority: -- → P1
Comment on attachment 8829892 [details]
Bug 1332692 - Block LastPass and Amazon Assistant from e10s rollout.

https://reviewboard.mozilla.org/r/106854/#review107902

That's the Acer specific version. Need to add abb@amazon.com as well.
Attachment #8829892 - Flags: review?(mozilla) → review-
For the record, abb-acer@amazon.com does not set mpc=false (yet).
Comment on attachment 8829892 [details]
Bug 1332692 - Block LastPass and Amazon Assistant from e10s rollout.

https://reviewboard.mozilla.org/r/106854/#review107906

LGTM
Attachment #8829892 - Flags: review?(mozilla) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e7c76b2f167
Block LastPass and Amazon Assistant from e10s rollout. r=mkaply
[Tracking Requested - why for this release]: Ok, Bug 1333423 by itself will cover the issue with Amazon Assistant. But if we have a dot release, this patch would also included a block for LastPass, which works on e10s (and is marked as compatible) but it has been reported as a major source of slowdowns.
Since bug 1333423 which is the most important thing is riding a dot release, I backed out this original patch from inbound. We can make a simpler one that only blocks LastPass and don't need to be pushed out in a hurry.

https://hg.mozilla.org/integration/mozilla-inbound/rev/59681d9f5e94 - Felipe Gomes - Backed out changeset 4e7c76b2f167 (bug 1332692)
Summary: Use system add-on to remove specific add-ons from receiving e10s activation → Use system add-on to block e10s activation for LastPass users
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40871b109d72
Block e10s rollout for LastPass. r=mkaply
Attachment #8829892 - Attachment is obsolete: true
Attachment #8832606 - Flags: review+
Jason, could you please sign this xpi for me?
Attachment #8832611 - Flags: feedback?(jthomas)
Attachment #8832611 - Flags: feedback?(jthomas)
Please see attached.
https://hg.mozilla.org/mozilla-central/rev/40871b109d72
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Stefan, could you do some QA on this for us?

Steps:

- Firefox 51 with a fresh profile
- Install a development version of LastPass from here: https://addons.mozilla.org/en-US/firefox/addon/lastpass-password-manager/versions/beta   (It must be a 4.* version)
- Restart and check that e10s is still enabled

- Install the XPI from comment 14 (just drag'n'drop it into Firefox)
- Restart Firefox (might need to restart twice) and check that e10s was disabled
Flags: needinfo?(stefan.georgiev)
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

I've tested the installation of the XPI file from comment 14. I can confirm that when it is installed and  Firefox is restarted the e10s is disabled (by add-ons). I will mark this as verified.
Status: RESOLVED → VERIFIED
Flags: needinfo?(stefan.georgiev)
Hey Jason, could you upload the signed XPI to ftp, as:

https://ftp.mozilla.org/pub/system-addons/e10srollout/e10srollout@mozilla.org-ff51-1.8-signed.xpi
Flags: needinfo?(jthomas)
Done.
Flags: needinfo?(jthomas)
Comment on attachment 8832606 [details] [diff] [review]
Block LastPass only, r=mkaply

Approval Request Comment
[Feature/Bug causing the regression]: Users of LastPass should remain blocked from e10s until it is no longer a performance problem. This has already been shipped to 51 release users through GoFaster. Taking this to beta is the easiest way for it to automatically continue through 52.
[User impact if declined]: Users of LastPass will be re-exposed to e10s once they get 52
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Already done
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just adding an entry in a well-tested blocklist
[String changes made/needed]: none
Attachment #8832606 - Flags: approval-mozilla-beta?
Attachment #8832606 - Flags: approval-mozilla-aurora?
I don't see RelMan approval on this bug. Can we get approval to ship this as a system add-on to 100% of 51?
Flags: needinfo?(jcristau)
(In reply to Cory Price [:ckprice] from comment #21)
> I don't see RelMan approval on this bug. Can we get approval to ship this as
> a system add-on to 100% of 51?

Gerry owns Fx51 release. Approving this on his behalf.
Flags: needinfo?(jcristau)
Comment on attachment 8832606 [details] [diff] [review]
Block LastPass only, r=mkaply

Patch to keep LastPass users on non-e10s till perf issues are fixed
Attachment #8832606 - Flags: approval-mozilla-beta?
Attachment #8832606 - Flags: approval-mozilla-beta+
Attachment #8832606 - Flags: approval-mozilla-aurora?
Attachment #8832606 - Flags: approval-mozilla-aurora+
Blocks: 1340195
You need to log in before you can comment on or make changes to this bug.