1340233 - Kill running Firefox instances before launching a test

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Jan Henning [:JanH]]

Running tests (e.g. mochitests) fails if the Firefox process is already running, because the startup commands passed by the test harness (use of custom profile etc.) are ignored in that case.

Since
- it's annoying always having to swipe Firefox away from the task list before starting the next run
- something (Sync ?) can cause the Firefox process to start up invisibly in background, so even if you did swipe Firefox away the test might still fail

it would be nice if the test harness could automatically kill any already running instance before starting the test run.

Comment 1

[Geoff Brown [:gbrown]]

https://dxr.mozilla.org/mozilla-central/rev/0eef1d5a39366059677c6d7944cfe8a97265a011/testing/mochitest/runtestsremote.py#357

Is this not working?

Comment 2

[Geoff Brown [:gbrown]]

I tested using the emulator from "mach android-emulator --version 6.0". I installed fennec, opened it, hit the Home button, used 'adb shell ps' to check the pid, then ran 'mach mochitest <dir>'. Debugging killProcess, I saw it attempt to kill the correct pid, and another 'adb shell ps' confirmed that the old pid was killed. The harness started a new instance of fennec with a new pid.

There might be variation in kill behavior across different versions of Android, especially before/after Android N. Also of course, shell permissions (root) will play a part on different devices.

Another possibility is that the harness is indeed reliably killing existing fennecs, but that their state is restored, making it look like they weren't killed. I think I see tabs from the killed fennec restored in the mochitest fennec...not sure what can be done about that.

Comment 3

[Jan Henning [:JanH]]

Maybe it might be worth using |adb shell am force-stop <package name>| as well (or perhaps even instead)?

Comment 4

[Jan Henning [:JanH]]

We have something implemented here (https://dxr.mozilla.org/mozilla-central/rev/0eef1d5a39366059677c6d7944cfe8a97265a011/testing/mozbase/mozrunner/mozrunner/base/device.py#97, respectively https://dxr.mozilla.org/mozilla-central/rev/0eef1d5a39366059677c6d7944cfe8a97265a011/testing/mozbase/mozdevice/mozdevice/adb_android.py#406).

Comment 5

[Geoff Brown [:gbrown]]

:gandalf reported something like this on irc, following up on a problem reported in bug 1354055. He was running on a device (rooted unknown, android version unknown) and running firefox before running mach. I had some concern that he might have multiple versions of firefox installed, but that was not substantiated.

I tried the same thing on emulators and found firefox was correctly killed before starting the test, but maybe there are cases where force-stop will work better.

I'd also like to try improving the logging to guard against this situation: "Cannot start test because firefox is already running!"?

Comment 6

[Geoff Brown [:gbrown]]

Attachment: try force-stop first in dm.killProcess

https://treeherder.mozilla.org/#/jobs?repo=try&revision=338eabf84289ae1a4a47453dad944c0f2b378f51

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8857270 [details] [diff] [review]
try force-stop first in dm.killProcess

Review of attachment 8857270 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c7b5d5f38f
Take more care when killing browser before starting Android tests; r=jmaher

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d6c7b5d5f38f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4bde2e27fdf2