1448697 - New code to kill already running Firefox instance doesn't work on my phone (kill: Operation not permitted)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Jan Henning [:JanH]]

Attachment: kill-running-firefox-error.log

The implementation provided in bug 1340233 worked flawlessly.

Recently, something must have changed because now I'm getting the attached error message if I try to run a test with my local Firefox build still running on my phone.

Comment 1

[Geoff Brown [:gbrown]]

Sorry :JanH -- I should have remembered this issue.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: use stop_application rather than pkill to stop the browser in most cases

This works fine for me locally on the emulator and with my (rooted) device.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=019210527a83b3de487bfb9b9787227cd7ef90ac

:JanH - Does this work for you?

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 8962351 [details] [diff] [review]
use stop_application rather than pkill to stop the browser in most cases

Review of attachment 8962351 [details] [diff] [review]:
-----------------------------------------------------------------

r+

Comment 4

[Jan Henning [:JanH]]

Comment on attachment 8962351 [details] [diff] [review]
use stop_application rather than pkill to stop the browser in most cases

Review of attachment 8962351 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, it's working again. Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5076991cfc93
Try to use force-stop instead of kill to end remote applications; r=bc

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5076991cfc93