Closed Bug 1340425 Opened 8 years ago Closed 6 years ago

Intermittent leakcheck | default process: 4734311 bytes leaked (AbstractThread, AbstractWatcher, Animation, AnimationEffectReadOnly, AnimationEffectTimingReadOnly, ...)

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mccr8)

References

Details

(Keywords: intermittent-failure, memory-leak, Whiteboard: [stockwell fixed:product])

Attachments

(1 file)

Bug 1340425 - Add back the magic GC in DoShutdown() to avoid intermittent leaks.
59 bytes, text/x-review-board-request
smaug
: review+
lizzard
: approval-mozilla-beta+
Details
Keywords: mlk
osx leaks on May 15 caused by bug 1364911, which was backed out.
Whiteboard: [stockwell fixed]
Depends on: 933741
Blocks: 933741
No longer depends on: 933741
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
This bug previously tracked a leak in browser-chrome tests; that was resolved around May 16.


Currently, this intermittent leak is observed in mochitest-a11y, and OF suggests it started around June 21.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=mochitest-a11y%20debug%20linux&tochange=7bdf1aa4e51482e51c0104845dc249cdc027a809&fromchange=8e1de9b8675384f6307830d381fcd195a432ea83 strongly suggests this leak started with https://hg.mozilla.org/integration/mozilla-inbound/rev/e2efdd8dcd82d74128f47410014d491e76276263, bug 833143.  I note https://bugzilla.mozilla.org/show_bug.cgi?id=833143#c41: "this may cause new intermittent leaks".

:mccr8 -- Just checking with you in case this leak is concerning or you can offer insight into resolving it.
Flags: needinfo?(continuation)
That's bad. I'll look into it. (Unfortunately, large leaks like this end up all looking the same as far as Treeherder classification goes.)
Flags: needinfo?(continuation)
Blocks: 833143
Assignee: nobody → continuation
Thanks for tracking down what caused this.
I see this has a steady stream of intermittents- not a high failure rate, but steady- :mccr8, I see you assigned yourself to this, is there a chance you had some WIP code to finish up?
Flags: needinfo?(continuation)
Oops, I forgot about this bug. I should just add back in the extra shutdown GC for debug builds and hope that fixes it.
Comment on attachment 8900428 [details]
Bug 1340425 - Add back the magic GC in DoShutdown() to avoid intermittent leaks.

https://reviewboard.mozilla.org/r/171778/#review177018
Attachment #8900428 - Flags: review?(bugs) → review+
Flags: needinfo?(continuation)
Keywords: leave-open
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4f88e70e596
Add back the magic GC in DoShutdown() to avoid intermittent leaks. r=smaug
No occurrences of this failure since I landed my patch.
status-firefox56: --- → affected
status-firefox57: --- → fixed
Comment on attachment 8900428 [details]
Bug 1340425 - Add back the magic GC in DoShutdown() to avoid intermittent leaks.

Approval Request Comment
[Feature/Bug causing the regression]: bug 833143
[User impact if declined]: None. This just fixes an intermittent failure on Treeherder.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This only affects debug builds.
[String changes made/needed]: None.
Attachment #8900428 - Flags: approval-mozilla-beta?
Whiteboard: [stockwell fixed] → [stockwell fixed:product]
Comment on attachment 8900428 [details]
Bug 1340425 - Add back the magic GC in DoShutdown() to avoid intermittent leaks.

Fix for failing tests on debug builds, avoids a leak, please uplift for beta 7.
Attachment #8900428 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/cb236dfdd7bb
status-firefox56: affected → fixed
(In reply to Andrew McCreight [:mccr8] from comment #28)
> [Is this code covered by automated tests?]: Yes.
> [Has the fix been verified in Nightly?]: Yes.
> [Needs manual test from QE? If yes, steps to reproduce]: No.

Setting qe-verify- based on Andrew's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
The leave-open keyword is there and there is no activity for 6 months.
:mccr8, maybe it's time to close this bug?
Flags: needinfo?(continuation)
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Flags: needinfo?(continuation)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: