1340471 - Test for: Legacy add-ons update is broken while permission preference is enabled

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 54.0a1 (2017-02-16)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Install an old version of Adblock Plus https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/versions/.
5.Go to about:addons -> Extensions and check for updates. 


[Expected Results]:
The add-on is successfully upgraded to the last available version.

[Actual Results]:
- No results are found while checking for updates.
- There are no errors thrown in Browser Console.
- See screencast: https://www.screencast.com/t/5OPlhxETFOl

[Regression Range]:
Last good revision: 2aede0a97bc685e163196cc451b947a04ae6a598
First bad revision: 28bb04d0338d2741bbc951566f156744a50060bc
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2aede0a97bc685e163196cc451b947a04ae6a598&tochange=28bb04d0338d2741bbc951566f156744a50060bc

I suspect that this issue was regressed by Bug 1330823.

Comment 1

[Nathan Froyd [:froydnj]]

Andrew, can you take a look at this?  Bug 1330823 looks like it might have caused this problem.

Comment 2

[Nathan Froyd [:froydnj]]

[Tracking Requested - why for this release]: Addon/WebExtension-related regressions are not good.

Comment 3

[Andy McKay]

I don't believe there's a need to set tracking flags on features behind flags, so removing.

Comment 4

[Andrew Swan [:aswan]]

This was fixed by the fix for bug 1339552, I can no longer reproduce it on Nightly (but I can reproduce it with a build from before the fix for bug 1339552 landed).  Leaving this open to add a test, but I'd like to tackle bug 130586 before adding the new test.

Comment 5

[Vasilica Tamas, QA [:vtamas]]

I confirm that the update is working now for legacy add-ons on Firefox 45.0a1 (2017-02-23). Tested across all platforms.

Comment 6

[:shell escalante]

left open to add test for this specific case - resolved in another bug

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Updating latest flag to fixed based on comments above. This should fall off our regression triage lists.

Comment 8

[:shell escalante]

checking if we have a test for this, if not just leave as P3

Comment 9

[Andrew Swan [:aswan]]

We don't have an automated test for this so leaving it open

Comment 10

[Andrew Swan [:aswan]]

This issue was specific to legacy extensions which we no longer support.