1340531 - A sideloaded add-on can be enabled/updated after it is removed

Status: NEW

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: gif.gif

[Affected versions]:
Firefox 54.0a1 (2017-02-16)
Firefox 53.0a2 (2017-02-17)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Restart the browser.
4.Install via sideloading method any add-on. 
5.Go to Panel Menu [≡] and click on sideloading notification.
6.Click “Remove” button that correspond to the sideloaded add-on.
7.Click “Enable” button from permissions pop-up.


[Expected Results]:
a) “Remove” button is disabled until any action is made using the options from permissions pop-up.
b) Removing the add-on should also discard the permissions pop-up.


[Actual Results]:
- The sideloaded add-on can be enabled even if it is already removed.
- The add-on icon is displayed in toolbar. (it is not functional)
- The icon disappears after refreshing the Add-ons Manager tab.  
- See attached video.

Comment 1

[Andrew Swan [:aswan]]

Markus, how do you propose we handle this scenario?

Comment 2

[Markus Jaritz [:designakt] (UX)]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #0)
> [Expected Results]:
> b) Removing the add-on should also discard the permissions pop-up.

That sounds great and matches what we hoped to achieve with showing about:addons while surfacing the dialog. - users being able to remove the side-loaded extension easily if the don't want it.

Comment 3

[CosminB]

This issue also reproduces for background updates, should I file a new bug or it will be fixed by this one?

Comment 4

[Markus Jaritz [:designakt] (UX)]

It would be great if you could add a gif of that second case and modify the title of the bug to reflect the more general problem.

Comment 5

[CosminB]

Attachment: UpdatedPermissions.gif

The background updates reproduces this issue a bit different, after the WebExtension is removed from about:addons, if you press the “Update” button from the pop-up will install the latest WebExtension version and it will be displayed in about:addons.