Closed
Bug 1340734
Opened 7 years ago
Closed 7 years ago
NAT simulator doesn't detect the use of TLS properly anymore
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | fixed |
firefox54 | --- | fixed |
backlog | webrtc/webaudio+ |
People
(Reporter: bwc, Assigned: bwc)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
drno
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
This blocks manual testing of TURN TLS.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
backlog: --- → webrtc/webaudio+
Rank: 25
Priority: -- → P2
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8838787 [details] Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. https://reviewboard.mozilla.org/r/113598/#review115222
Attachment #8838787 -
Flags: review?(drno) → review+
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ad5216e9145 Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. r=drno
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ad5216e9145
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Blocks: 1336507
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
No longer depends on: 1336507
Comment 7•7 years ago
|
||
From https://bugzilla.mozilla.org/show_bug.cgi?id=1336507#c17, do we still need this on 53 beta for the uplift in bug 1336507 ? Thanks.
Flags: needinfo?(docfaraday)
Comment 9•7 years ago
|
||
OK, can you request uplift to beta in this bug too, so we keep all our ticky boxes ticked?
Flags: needinfo?(docfaraday)
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8838787 [details] Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. Approval Request Comment [Feature/Bug causing the regression]: Bug 1336507 [User impact if declined]: It will be very difficult to QE TURN/TLS without this fix. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: The testing that QE performs for TURN/TLS will end up covering this. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: Not really. [Why is the change risky/not risky?]: It involves code that is only used when some hidden prefs are set, that only someone doing manual testing would need. [String changes made/needed]: None.
Flags: needinfo?(docfaraday)
Attachment #8838787 -
Flags: approval-mozilla-beta?
Attachment #8838787 -
Flags: approval-mozilla-aurora?
Comment 11•7 years ago
|
||
Comment on attachment 8838787 [details] Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. Fixes to support TLS, let's uplift to beta.
Attachment #8838787 -
Flags: approval-mozilla-beta?
Attachment #8838787 -
Flags: approval-mozilla-beta+
Attachment #8838787 -
Flags: approval-mozilla-aurora?
Attachment #8838787 -
Flags: approval-mozilla-aurora+
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/db6fcf5fe806
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•