1340734 - NAT simulator doesn't detect the use of TLS properly anymore

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

This blocks manual testing of TURN TLS.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507.

Review commit: https://reviewboard.mozilla.org/r/113598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113598/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8838787 [details]
Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507.

https://reviewboard.mozilla.org/r/113598/#review115222

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad5216e9145
Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. r=drno

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ad5216e9145

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Do we know when this regressed?

Comment 6

[Byron Campen [:bwc]]

Bug 1336507

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1336507#c17, do we still need this on 53 beta for the uplift in bug 1336507 ? Thanks.

Comment 8

[Byron Campen [:bwc]]

Yes.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, can you request uplift to beta in this bug too, so we keep all our ticky boxes ticked?

Comment 10

[Byron Campen [:bwc]]

Comment on attachment 8838787 [details]
Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507.

Approval Request Comment
[Feature/Bug causing the regression]:

   Bug 1336507

[User impact if declined]:

   It will be very difficult to QE TURN/TLS without this fix.

[Is this code covered by automated tests?]:

   No.

[Has the fix been verified in Nightly?]:

   Yes.

[Needs manual test from QE? If yes, steps to reproduce]:

   The testing that QE performs for TURN/TLS will end up covering this.

[List of other uplifts needed for the feature/fix]:

   None.

[Is the change risky?]:

   Not really.

[Why is the change risky/not risky?]:

   It involves code that is only used when some hidden prefs are set, that only someone doing manual testing would need.

[String changes made/needed]:

   None.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8838787 [details]
Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507.

Fixes to support TLS, let's uplift to beta.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/db6fcf5fe806