1340967 - "Search" input label in Settings of Site Data is not vertically center-aligned

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Fischer [:Fischer]]

Attachment: not_aligned_search_label.png

STR:
1. Set browser.storageManager.enabled to true
2. Go to about:preferences > Advanced > Network
3. Scroll to Site Data
4. Click "Settings" button to open the Settings dialog

Actual result:
"Search" input label in Settings of Site Data is not vertically center-aligned. See the attached not_aligned_search_label.png.

Expected result:
"Search" input label in Settings of Site Data is vertically center-aligned.

Comment 1

[Fischer [:Fischer]]

Attachment: aligned_search_label.png

Comment 2

[Fischer [:Fischer]]

Attachment: Bug 1340967 - Search input label in Settings of Site Data is not vertically center-aligned

Review commit: https://reviewboard.mozilla.org/r/113800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113800/

Comment 3

[Fischer [:Fischer]]

Comment on attachment 8839054 [details]
Bug 1340967 - Search input label in Settings of Site Data is not vertically center-aligned

Gijs,
Fix to align "Search" input label. Please see [1], thanks.
[1] attachment 8839051 [details]: aligned_search_label.png

Comment 4

[:Gijs (out for now; he/him)]

Comment on attachment 8839054 [details]
Bug 1340967 - Search input label in Settings of Site Data is not vertically center-aligned

https://reviewboard.mozilla.org/r/113800/#review115386

I wonder if this should use 'baseline' instead. Can you check and use either that or 'center' as makes sense? (see docs at https://developer.mozilla.org/en-US/docs/Web/CSS/box-align )

Comment 5

[Fischer [:Fischer]]

(In reply to :Gijs from comment #4)
> Comment on attachment 8839054 [details]
> Bug 1340967 - Search input label in Settings of Site Data is not vertically
> center-aligned
> 
> https://reviewboard.mozilla.org/r/113800/#review115386
> 
> I wonder if this should use 'baseline' instead. Can you check and use either
> that or 'center' as makes sense? (see docs at
> https://developer.mozilla.org/en-US/docs/Web/CSS/box-align )
Tried 'baseline' and it turned out that the position is not centered but slightly upward shifted.
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9bf47b562e2951855bcd67943bb3dc8936f2200

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e25127db470c
Search input label in Settings of Site Data is not vertically center-aligned r=Gijs

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e25127db470c

Comment 8

[u428464]

I think it would be better to have the "search" as placeholder text like it has been done in bug 1324171.

Comment 9

[:Gijs (out for now; he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #8)
> I think it would be better to have the "search" as placeholder text like it
> has been done in bug 1324171.

Fischer, can you check with UX and file a followup for this? Thanks.

Comment 10

[Fischer [:Fischer]]

(In reply to :Gijs from comment #9)
> (In reply to Guillaume C. [:ge3k0s] from comment #8)
> > I think it would be better to have the "search" as placeholder text like it
> > has been done in bug 1324171.
> 
Mark,
It seems there is a rule for the search label of a search input box.
Could you please check, thanks.

Comment 11

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #10)
> (In reply to :Gijs from comment #9)
> > (In reply to Guillaume C. [:ge3k0s] from comment #8)
> > > I think it would be better to have the "search" as placeholder text like it
> > > has been done in bug 1324171.
> > 
> Mark,
> It seems there is a rule for the search label of a search input box.
> Could you please check, thanks.
Just check with UX: Mark. The spec will be updated.

Comment 12

[Tanvir Rahman]

I have reproduced this bug with Nightly 54.0a1 (2017-02-19) on Windows 10, 64 bit!

The Bug's fix is now verified on Latest Nightly 54.0a1

Build ID 	20170228030203
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
[bugday-20170301]

Comment 13

[Azmina]

Attachment: Search_is_less_center_aligned.JPG

While verifying the fix of this bug with Latest Nightly 54.0a1 (2017-02-28) on Windows 8.1, 64 bit, I felt that the "search" is still less center aligned. 

I have attached a screenshot of the fix that I saw. But this doesn't resemble to the one of comment 1. Is the current fix (attached in the attachment) should be expected as the fix?

Comment 14

[Adrian Oniga]

While testing with 54.0a1 (2017-03-01) (32-bit) i see the same issue as Azmina : label is under aligned

Comment 15

[:Gijs (out for now; he/him)]

(In reply to Adrian Oniga from comment #14)
> While testing with 54.0a1 (2017-03-01) (32-bit) i see the same issue as
> Azmina : label is under aligned

This is going away in bug 1343477 anyway, but I expect what you're comparing is the end of the label only, which is obviously shorter, rather than taking into account the rest of the label, with the top of the S and h. If you measure those distances, this looks centered to me (plus, if align=center didn't do its job here, that wouldn't be this bug's fault but a separate bug in XUL or Layout land).

Given all of this, going to mark this verified.