Closed
Bug 1340967
Opened 7 years ago
Closed 7 years ago
"Search" input label in Settings of Site Data is not vertically center-aligned
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | verified |
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [storage-v1])
Attachments
(4 files)
STR: 1. Set browser.storageManager.enabled to true 2. Go to about:preferences > Advanced > Network 3. Scroll to Site Data 4. Click "Settings" button to open the Settings dialog Actual result: "Search" input label in Settings of Site Data is not vertically center-aligned. See the attached not_aligned_search_label.png. Expected result: "Search" input label in Settings of Site Data is vertically center-aligned.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → fliu
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8839054 [details] Bug 1340967 - Search input label in Settings of Site Data is not vertically center-aligned Gijs, Fix to align "Search" input label. Please see [1], thanks. [1] attachment 8839051 [details]: aligned_search_label.png
Attachment #8839054 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8839054 [details] Bug 1340967 - Search input label in Settings of Site Data is not vertically center-aligned https://reviewboard.mozilla.org/r/113800/#review115386 I wonder if this should use 'baseline' instead. Can you check and use either that or 'center' as makes sense? (see docs at https://developer.mozilla.org/en-US/docs/Web/CSS/box-align )
Attachment #8839054 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to :Gijs from comment #4) > Comment on attachment 8839054 [details] > Bug 1340967 - Search input label in Settings of Site Data is not vertically > center-aligned > > https://reviewboard.mozilla.org/r/113800/#review115386 > > I wonder if this should use 'baseline' instead. Can you check and use either > that or 'center' as makes sense? (see docs at > https://developer.mozilla.org/en-US/docs/Web/CSS/box-align ) Tried 'baseline' and it turned out that the position is not centered but slightly upward shifted. TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9bf47b562e2951855bcd67943bb3dc8936f2200
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e25127db470c Search input label in Settings of Site Data is not vertically center-aligned r=Gijs
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e25127db470c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I think it would be better to have the "search" as placeholder text like it has been done in bug 1324171.
Comment 9•7 years ago
|
||
(In reply to Guillaume C. [:ge3k0s] from comment #8) > I think it would be better to have the "search" as placeholder text like it > has been done in bug 1324171. Fischer, can you check with UX and file a followup for this? Thanks.
Flags: needinfo?(fliu)
Assignee | ||
Comment 10•7 years ago
|
||
(In reply to :Gijs from comment #9) > (In reply to Guillaume C. [:ge3k0s] from comment #8) > > I think it would be better to have the "search" as placeholder text like it > > has been done in bug 1324171. > Mark, It seems there is a rule for the search label of a search input box. Could you please check, thanks.
Flags: needinfo?(fliu) → needinfo?(mliang)
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Fischer [:Fischer] from comment #10) > (In reply to :Gijs from comment #9) > > (In reply to Guillaume C. [:ge3k0s] from comment #8) > > > I think it would be better to have the "search" as placeholder text like it > > > has been done in bug 1324171. > > > Mark, > It seems there is a rule for the search label of a search input box. > Could you please check, thanks. Just check with UX: Mark. The spec will be updated.
Flags: needinfo?(mliang)
Comment 12•7 years ago
|
||
I have reproduced this bug with Nightly 54.0a1 (2017-02-19) on Windows 10, 64 bit! The Bug's fix is now verified on Latest Nightly 54.0a1 Build ID 20170228030203 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0 [bugday-20170301]
Comment 13•7 years ago
|
||
While verifying the fix of this bug with Latest Nightly 54.0a1 (2017-02-28) on Windows 8.1, 64 bit, I felt that the "search" is still less center aligned. I have attached a screenshot of the fix that I saw. But this doesn't resemble to the one of comment 1. Is the current fix (attached in the attachment) should be expected as the fix?
Comment 14•7 years ago
|
||
While testing with 54.0a1 (2017-03-01) (32-bit) i see the same issue as Azmina : label is under aligned
Comment 15•7 years ago
|
||
(In reply to Adrian Oniga from comment #14) > While testing with 54.0a1 (2017-03-01) (32-bit) i see the same issue as > Azmina : label is under aligned This is going away in bug 1343477 anyway, but I expect what you're comparing is the end of the label only, which is obviously shorter, rather than taking into account the rest of the label, with the top of the S and h. If you measure those distances, this looks centered to me (plus, if align=center didn't do its job here, that wouldn't be this bug's fault but a separate bug in XUL or Layout land). Given all of this, going to mark this verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•