Closed Bug 1343477 Opened 7 years ago Closed 7 years ago

Search label should be a placeholder text in Settings of Site Data

Categories

(Firefox :: Settings UI, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [storage-v1])

Attachments

(1 file)

Search label should be a placeholder text in Settings of Site Data on host
Summary: Search label should be a placeholder text in Settings of Site Data on host → Search label should be a placeholder text in Settings of Site Data
Comment on attachment 8842365 [details]
Bug 1343477 - Search label should be a placeholder text in Settings of Site Data,

Gijs,
This is a follow-up bug for [1].
Please take a look, thanks.


[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1340967#c9
Attachment #8842365 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8842365 [details]
Bug 1343477 - Search label should be a placeholder text in Settings of Site Data,

https://reviewboard.mozilla.org/r/116234/#review117814

Please ensure you request review on mozreview.

Also, please remove the alignment attribute that is now no longer necessary.
Attachment #8842365 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8842365 [details]
Bug 1343477 - Search label should be a placeholder text in Settings of Site Data,

https://reviewboard.mozilla.org/r/116234/#review117814

Updated, thanks.
Comment on attachment 8842365 [details]
Bug 1343477 - Search label should be a placeholder text in Settings of Site Data,

https://reviewboard.mozilla.org/r/116234/#review118178
Attachment #8842365 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d85f0b3dea8
Search label should be a placeholder text in Settings of Site Data, r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5d85f0b3dea8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.