Closed
Bug 1341019
Opened 7 years ago
Closed 7 years ago
'item' is not defined in autocomplete-richlistitem#_onChanged after bug 1326138
Categories
(Toolkit :: Form Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
People
(Reporter: standard8, Assigned: ralin)
References
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1326138 has done some refactoring of autocomplete.xml. I'm current trying to get the no-undef rule enabled for eslint, and it has brought up to issues: /Users/mark/dev/gecko/toolkit/content/widgets/autocomplete.xml 2050:30 error 'item' is not defined. no-undef (eslint) 2053:14 error 'item' is not defined. no-undef (eslint) The blame points to bug 1326138. 'item' is not defined in autocomplete-richlistitem#_onChanged Additionally, I can't find any obvious callers of it - there's a call to `onChanged` but not `_onChanged`. Therefore, this looks like a mistake in the changes made.
Flags: needinfo?(ralin)
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #0) > Bug 1326138 has done some refactoring of autocomplete.xml. I'm current > trying to get the no-undef rule enabled for eslint, and it has brought up to > issues: > > /Users/mark/dev/gecko/toolkit/content/widgets/autocomplete.xml > 2050:30 error 'item' is not defined. no-undef (eslint) > 2053:14 error 'item' is not defined. no-undef (eslint) > > The blame points to bug 1326138. > > 'item' is not defined in autocomplete-richlistitem#_onChanged > > Additionally, I can't find any obvious callers of it - there's a call to > `onChanged` but not `_onChanged`. > > Therefore, this looks like a mistake in the changes made. Thanks Mark, It's a mistake I didn't notice while refactoring, I'll have a quick fix to this :-)
Flags: needinfo?(ralin)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47e8ed4b81aad07adfb8b0dfac5a36d74e0ae50c
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → affected
Version: unspecified → 54 Branch
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8839155 [details] Bug 1341019 - Fix undef item variable in _onChanged(). https://reviewboard.mozilla.org/r/113876/#review116660 I think Drew has been afk, so I'm going to steal this review to unblock the patch I would like to land ;-) This looks good to me and the changes make sense, it'd be nice to get this covered by a unit test at some stage, but I don't think that's critical for this patch to land.
Attachment #8839155 -
Flags: review+
Reporter | ||
Updated•7 years ago
|
Attachment #8839155 -
Flags: review?(adw)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Thank you Mark :) Rebased and updated reviewer. I'm afraid that I could not create a valid unit test in a short time, so let's land this patch first in order to not block your patch.
Keywords: checkin-needed
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7d197ff438e Fix undef item variable in _onChanged(). r=standard8
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7d197ff438e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•