Stop setting background-color: transparent and border: none on .button-menu-dropmarker and .button-menubutton-dropmarker

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: deepsrijit1105, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla54
Unspecified
Windows
good-first-bug
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Bug 1340626 removed the fallback border and background styling from dropmarker.css, so now we can stop removing the border and background here: https://hg.mozilla.org/mozilla-central/annotate/16effd5b21ab03629feca04b5b83911bb757394c/toolkit/themes/windows/global/button.css#l91
(Reporter)

Updated

2 years ago
Blocks: 1341048
(Assignee)

Comment 1

2 years ago
Posted patch initial_patchSplinter Review
Hi Dao,

I have done the necessary changed :-)

Thanks.
Attachment #8839649 - Flags: review?(dao+bmo)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8839649 [details] [diff] [review]
initial_patch

Thanks, looks good!
Attachment #8839649 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

2 years ago
Assignee: nobody → deepsrijit1105

Comment 3

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/044e3c4af432
Stop setting background-color: transparent and border: none on .button-menu-dropmarker and .button-menubutton-dropmarker. r=dao

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/044e3c4af432
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.