Closed Bug 1341047 Opened 9 years ago Closed 9 years ago

Stop setting background-color: transparent and border: none on .button-menu-dropmarker and .button-menubutton-dropmarker

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: dao, Assigned: deepsrijit1105, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

initial_patch
999 bytes, patch
dao
: review+
Details | Diff | Splinter Review
Bug 1340626 removed the fallback border and background styling from dropmarker.css, so now we can stop removing the border and background here: https://hg.mozilla.org/mozilla-central/annotate/16effd5b21ab03629feca04b5b83911bb757394c/toolkit/themes/windows/global/button.css#l91
Blocks: 1341048
Attached patch initial_patch — — Splinter Review
Hi Dao, I have done the necessary changed :-) Thanks.
Attachment #8839649 - Flags: review?(dao+bmo)
Comment on attachment 8839649 [details] [diff] [review] initial_patch Thanks, looks good!
Attachment #8839649 - Flags: review?(dao+bmo) → review+
Assignee: nobody → deepsrijit1105
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/044e3c4af432 Stop setting background-color: transparent and border: none on .button-menu-dropmarker and .button-menubutton-dropmarker. r=dao
https://hg.mozilla.org/mozilla-central/rev/044e3c4af432
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: