Closed Bug 1341362 Opened 3 years ago Closed 3 years ago

Use default args for RendererOptions in webrender_bindings where possible

Categories

(Core :: Graphics: WebRender, defect, P3)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

https://github.com/servo/webrender/commit/457a25a7a08524bd618f463762f57cd43a90646f adds a blob_image_renderer field to RendererOptions. This causes build bustage in webrender_bindings unless the field is added to our instantiation of RendererOptions. Instead of this whack-a-mole we should just use the .. Default::default() notation to automatically pick up the WR defaults and just override the things we want to override.
Comment on attachment 8839573 [details]
Bug 1341362 - Use default values for RendererOptions instead of explicitly specifying each one.

https://reviewboard.mozilla.org/r/114164/#review116038
Attachment #8839573 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/684fa301b65d
Use default values for RendererOptions instead of explicitly specifying each one. r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.