Closed Bug 1340270 Opened 3 years ago Closed 3 years ago

Update webrender to edc74274d28b1fa1229a1d1ea05027f57172b992

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(5 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1339530 +++

I'm filing this as a placeholder bug for the next webrender update. I will be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I have a complicated half-baked idea involving ifdefs and bug numbers to keep our in-tree bindings patched as we encounter changes on the webrender side, so that we can continue to catch additional changes/breakages rather than stopping after the first one. We can jump over that bridge when we get there though.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ b2476ef9d6a3535a8a501b0fdd2fde4e78706a48

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe40852606182e4d2ccf9a556228959de956ddee

This one has some oranges, but I believe they are all from bug 1340067 as those oranges are showing up on the graphics branch too. I backed out that bug so the next WR update-test shouldn't have these.
WR @ b2476ef9d6a3535a8a501b0fdd2fde4e78706a48 (again, but with newer graphics branch this time)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00d376f1992ca921e3bbafe6c01a8a30bb0ce7bf
WR @ b5230b9b84a4a50d84f037f7227187b80d6818d3.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f4e6754ba3832aa272f98f0223f6f460511d739

Build is busted because the Cargo.toml file references dwrote from the git repo rather than a crates.io version. This breaks the vendoring. I filed https://github.com/servo/webrender/issues/900
WR @ 1e60982e766462772dcaf1776b65485f97bcedd7

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd9a805b0eb42da5025eab5cf1f0e713d802877e

The dwrote-rs issue from comment 4 was fixed, but it looks like there were euclid updates so stuff is broken again. I'll try implementing my half-baked idea to work around this.
I figured out a simpler way to apply extra patches into the try pushes. I have a build working locally, the 4pm cron push should produce a working try build. I'll make sure all the extra patches needed are on a bug somewhere - I'm putting one here and one is in bug 1341362 (because it can land right away).
Attachment #8839585 - Flags: review+
I'm putting the cron job on hold for now. It's hard to anticipate and automate fixing all the kinds of build bustage that can result from a WR update. I did a manual try push with the latest WR (cset ba8ce0c81ee1e9b69856a3ecb374486137b5bd92):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c96f4cb93e3e4d37233640e2a59b620fbaef5811
There is also an (intermittent) opt M-e10s(gpu) failure, https://treeherder.mozilla.org/logviewer.html#?job_id=79440329&repo=try&lineNumber=2367. Not sure what that's about, it might be low frequency enough for us to ignore for now. I did some retriggers to check.
Another try push, with the fix from kvark (#916) and the desired patches from lsalzman (#912): https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e3dec0a20dbf829d77c4aa8c9d48de5d408edfd
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to edc74274d28b1fa1229a1d1ea05027f57172b992
Comment on attachment 8840277 [details]
Bug 1340270 - Update webrender and webrender_traits to cset edc74274d28b1fa1229a1d1ea05027f57172b992.

https://reviewboard.mozilla.org/r/114770/#review116238
Attachment #8840277 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8840278 [details]
Bug 1340270 - Re-vendor dependencies in third_party/rust.

https://reviewboard.mozilla.org/r/114772/#review116240
Comment on attachment 8840278 [details]
Bug 1340270 - Re-vendor dependencies in third_party/rust.

https://reviewboard.mozilla.org/r/114772/#review116242
Attachment #8840278 - Flags: review?(jmuizelaar) → review+
Sorry for the churn, decided on a better split of the patches. Parts 1 and 3 are basically copypaste/autogenerated now.
Comment on attachment 8840279 [details]
Bug 1340270 - Update webrender_bindings glue for push_border API changes.

https://reviewboard.mozilla.org/r/114774/#review116244
Attachment #8840279 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8840280 [details]
Bug 1340270 - Update webrender_bindings glue for add_image and add_raw_font API changes.

https://reviewboard.mozilla.org/r/114776/#review116246
Attachment #8840280 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8d780fbcfa7d
Update webrender and webrender_traits to cset edc74274d28b1fa1229a1d1ea05027f57172b992. r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8840284 [details]
Bug 1340270 - Update Cargo.toml and Cargo.lock files based on updated webrender.

This patch was extracted from the earlier part 1 and part 2 (which are now part 1 and part 3 in the review series) and basically got reviewed/can be rubberstamped. I squashed all the patches together for landing anyway.
Attachment #8840284 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.